From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932497Ab3LDOGA (ORCPT ); Wed, 4 Dec 2013 09:06:00 -0500 Received: from mail-bk0-f44.google.com ([209.85.214.44]:62934 "EHLO mail-bk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932433Ab3LDOF7 (ORCPT ); Wed, 4 Dec 2013 09:05:59 -0500 Date: Wed, 4 Dec 2013 15:04:59 +0100 From: Thierry Reding To: Meelis Roos Cc: Sebastian Hesselbarth , Grant Likely , Rob Herring , Benjamin Herrenschmidt , Russell King , Marc Kleine-Budde , Scott Wood , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux Kernel list , David Miller Subject: Re: [PATCH v2] OF: base: match each node compatible against all given matches first Message-ID: <20131204140457.GA2272@ulmo.nvidia.com> References: <1385663785-8643-1-git-send-email-sebastian.hesselbarth@gmail.com> <1386078720-8756-1-git-send-email-sebastian.hesselbarth@gmail.com> <529E614B.3070307@gmail.com> <20131204094010.GO19943@ulmo.nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --M9NhX3UHpAaciwkO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 04, 2013 at 03:08:39PM +0200, Meelis Roos wrote: > > I added Meelis on Cc because he found a regression with my original > > proposal (107a84e61cdd "of: match by compatible property first"). That > > got later reverted in commit bc51b0c22ceb (Revert "of: match by > > compatible property first"). Here's the commit message for reference: > >=20 > > commit bc51b0c22ceb > > Author: Linus Torvalds > > Date: Tue Jul 10 12:49:32 2012 -0700 > >=20 > > Revert "of: match by compatible property first" > >=20 > > This reverts commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6. > >=20 > > Meelis Roos reports a regression since 3.5-rc5 that stops Sun Fire = V100 > > and Sun Netra X1 sparc64 machines from booting, hanging after enabl= ing > > serial console. He bisected it to commit 107a84e61cdd. > >=20 > > Rob Herring explains: > > "The problem is match combinations of compatible plus name and/or = type > > fail to match correctly. I have a fix for this, but given how la= te it > > is for 3.5 I think it is best to revert this for now. There coul= d be > > other cases that rely on the current although wrong behavior. I = will > > post an updated version for 3.6." > >=20 > > Bisected-and-reported-by: Meelis Roos > > Requested-by: Rob Herring > > Cc: Thierry Reding > > Cc: Grant Likely > > Signed-off-by: Linus Torvalds > >=20 > > So if Meelis still has access to the Sun Fire V100 and Sun Netra X1 > > machines that regressed last time around, it'd be great to get this > > patch tested on them to verify that it indeed fixes the problem and > > doesn't regress. >=20 > OK, I had forgotten about that. Yeah, I had always meant to come back to it, but that never quite happened, so I'm all the more glad that Sebastian took over. > Tested successfully on the same Sun Fire V100 and Sun Netra X1, on top=20 > of 3.13-rc2. The sunsu console is detected fine and I see no problem for= =20 > now. Excellent. Thanks for testing! Rob, I guess this should be reasonable safe then to take for a spin in linux-next? Thierry --M9NhX3UHpAaciwkO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSnzaJAAoJEN0jrNd/PrOhvm4QAIpXTYGYgwUTzndgfiMOx1Ax j34bf4q2SJSyqxp6TY/7lHpNd3epqsAyK0r5AKh4YX2adJMt6Z4o2WKouP3eAzNa 9fPvLWSh7j5TKf6KDAAJAuM6SI6X3yH6H6mNn95yz3MyE4aieB7hziXPfRACYWLc NO4mmApG5pO7F5+JiMLI81vbfRae23lp/swg1/OSCjc2Cvvw8mQlt3hT7QV8nOMt +X125WK0WPstc4ERy3EyUHv5rFpJPQWeuN92j1AIcgOn01tXZFzdJP3oWqmbiFEE 2BM2ufZaqVpqE8SdMSobNTU5Y+kJJ1yY2uFjGSYq2rlzphwhr6RPJn+qtK2RV95I SQLeQVrra6WYtNsN2IDx6vvJL6xmCCBmmGDcWdwFB/MupksPe6NzKLoQlqO/0u7y GB9rYSP2dNship0o4TzIcXeg+vA+45kYwCbx2UtTuhX8T39ZJtxZwnW1dorymKsN DnxdAEQHJ/GgpKJvkAKKSp/ixsXiZ0uJyIPL5MxOkUeMQdvrJAduO5iyxvN2bc8V JRkJyCjDd7MF68XxsQLp14ELwEjujzarPOgGb5SfZnX6hLUb9xqZXS8yNSzALQYk hWjkTEh0W7EAZmahu3H2Tm3b63fv6PdQanJk4fDt0K34Z7MsS7kUXyzInQiiRWz6 dOoqEwHi1vUQXiItKGNZ =R4EY -----END PGP SIGNATURE----- --M9NhX3UHpAaciwkO--