From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932502Ab3LDPMm (ORCPT ); Wed, 4 Dec 2013 10:12:42 -0500 Received: from mga02.intel.com ([134.134.136.20]:64003 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932178Ab3LDPMl (ORCPT ); Wed, 4 Dec 2013 10:12:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,825,1378882800"; d="scan'208";a="446781373" Date: Wed, 4 Dec 2013 17:12:13 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ingo Molnar Cc: intel-gfx@lists.freedesktop.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] x86: Add Intel graphics stolen memory quirk for gen2 platforms Message-ID: <20131204151213.GW10036@intel.com> References: <1386085793-317-1-git-send-email-ville.syrjala@linux.intel.com> <1386085793-317-3-git-send-email-ville.syrjala@linux.intel.com> <20131204090814.GA32218@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20131204090814.GA32218@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 04, 2013 at 10:08:14AM +0100, Ingo Molnar wrote: > > * ville.syrjala@linux.intel.com wrote: > > > v2: Rewrite to use the TOM-TSEG_SIZE-stolen_size and TOUD methods > > I guess v2 is a reaction to my review feedback? I got no reply to my > mail from you so I'm not sure and I'd like to know whether all > feedback was addressed. Actually this was mostly insipired by a private mail from hpa. I forgot to reply to your mail, sorry about that. But anyways, I think apart from your comment about the KB/MB macros, the rest of the comments no longer apply. And as far as those macros go, there seem to be similar macros already sprinkled around in various places, so I'm not sure how big of a fallout we'd have if I just stick them into kernel.h. -- Ville Syrjälä Intel OTC