From: Ingo Molnar <mingo@kernel.org>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] x86: Add Intel graphics stolen memory quirk for gen2 platforms
Date: Wed, 4 Dec 2013 16:15:50 +0100 [thread overview]
Message-ID: <20131204151550.GA5502@gmail.com> (raw)
In-Reply-To: <20131204151213.GW10036@intel.com>
* Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Dec 04, 2013 at 10:08:14AM +0100, Ingo Molnar wrote:
> >
> > * ville.syrjala@linux.intel.com <ville.syrjala@linux.intel.com> wrote:
> >
> > > v2: Rewrite to use the TOM-TSEG_SIZE-stolen_size and TOUD methods
> >
> > I guess v2 is a reaction to my review feedback? I got no reply to my
> > mail from you so I'm not sure and I'd like to know whether all
> > feedback was addressed.
>
> Actually this was mostly insipired by a private mail from hpa. I forgot
> to reply to your mail, sorry about that.
>
> But anyways, I think apart from your comment about the KB/MB macros,
> the rest of the comments no longer apply. [...]
Ok.
> [...] And as far as those macros go, there seem to be similar macros
> already sprinkled around in various places, so I'm not sure how big
> of a fallout we'd have if I just stick them into kernel.h.
That was a separate suggestion, outside the scope of this series.
Anyway, this v2 series looks good.
Thanks,
Ingo
next prev parent reply other threads:[~2013-12-04 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1386085793-317-1-git-send-email-ville.syrjala@linux.intel.com>
2013-12-03 15:49 ` [PATCH 1/6] x86: Add vfunc for Intel graphics stolen memory base address ville.syrjala
2013-12-03 15:49 ` [PATCH v2 2/6] x86: Add Intel graphics stolen memory quirk for gen2 platforms ville.syrjala
2013-12-04 9:08 ` Ingo Molnar
2013-12-04 15:12 ` Ville Syrjälä
2013-12-04 15:15 ` Ingo Molnar [this message]
2014-01-07 15:28 ` [PATCH v3 " ville.syrjala
2014-02-04 12:47 ` Ville Syrjälä
2014-02-04 13:02 ` [Intel-gfx] " Daniel Vetter
2014-02-05 5:41 ` Ingo Molnar
2013-12-03 15:49 ` [PATCH 3/6] x86: Print the Intel graphcis stolen memory range ville.syrjala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204151550.GA5502@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=ville.syrjala@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox