Re: [PATCH v9] x86, apic, kexec, Documentation: Add disable_cpu_apic kernel parameter

[Vivek Goyal <vgoyal@redhat.com>]

On Wed, Dec 04, 2013 at 03:24:43PM +0900, HATAYAMA Daisuke wrote:
> (2013/12/04 12:08), HATAYAMA Daisuke wrote:
> >(2013/12/04 0:25), Vivek Goyal wrote:
> >>On Tue, Dec 03, 2013 at 10:32:26AM +0900, HATAYAMA Daisuke wrote:
> >>
> >>[..]
> >>>
> >>>diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> >>>index 50680a5..dd77bec 100644
> >>>--- a/Documentation/kernel-parameters.txt
> >>>+++ b/Documentation/kernel-parameters.txt
> >>>@@ -774,6 +774,15 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
> >>>      disable=    [IPV6]
> >>>              See Documentation/networking/ipv6.txt.
> >>>
> >>>+    disable_cpu_apicid= [X86,APIC,KEXEC,SMP]
> >>
> >>Hi Hatayama,
> >>
> >>We are almost there. A minor nit. Why have we specified KEXEC here. This
> >>parameter disabled_cpu_apicid does not seem to dependon CONFIG_KEXEC?
> >>
> >>Jerry, this patch looks good to me. Does it work on your system?
> >>
> >
> >Because primary user for the option is currently kexec/kdump only.
> >
> >I referred to acpi_rsdp description:
> >
> >         acpi_rsdp=      [ACPI,EFI,KEXEC]
> >                         Pass the RSDP address to the kernel, mostly used
> >                         on machines running EFI runtime service to boot the
> >                         second kernel for kdump.
> >
> 
> Indo-san, who introduced acpi_rsdp and KEXEC tag, told me that historical reason
> why KEXEC tag was introduced. disable_cpu_apicid is generic at least in the
> current version, so the tag doesn't need to be specified here.

Also Documentation/kernel-parameters.txt says following.

"The parameters listed below are only valid if certain kernel build options
 were enabled and if respective hardware is present. The text in square
 brackets at the beginning of each description states the restrictions within
 which a parameter is applicable:"

As above parameter is not dependent on CONFIG_KEXEC, we should remove
KEXEC from the brackets.

acpi_rsdp is defined only if CONFIG_KEXEC is present, so there specifying
kexec makes sense.

#ifdef CONFIG_KEXEC
static unsigned long acpi_rsdp;
static int __init setup_acpi_rsdp(char *arg)
{
        acpi_rsdp = simple_strtoul(arg, NULL, 16);
        return 0;
}
early_param("acpi_rsdp", setup_acpi_rsdp);
#endif

Thanks
Vivek


> 
> I'll post a new version soon.
> 
> -- 
> Thanks.
> HATAYAMA, Daisuke