public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Adrien Vergé" <adrienverge@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Russell King <linux@arm.linux.org.uk>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	Will Deacon <will.deacon@arm.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control
Date: Wed, 4 Dec 2013 15:02:39 -0800	[thread overview]
Message-ID: <20131204230239.GB9205@kroah.com> (raw)
In-Reply-To: <CANsc=4X7ThCvgz9bfu1ZZg9FCti5SMdbXL5tA584z-oZ_HEByg@mail.gmail.com>

On Wed, Dec 04, 2013 at 04:12:56PM -0500, Adrien Vergé wrote:
> 2013/12/4 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> > Your pid implementation is broken, see my other email about that :(
> 
> Thank you for your remarks on pid. I'll try to correct that.
> 
> > And again, what's wrong with the existing tracing functionalty that is
> > processor agnostic?  Why can't we just delete this driver today and use
> > the existing trace code?
> 
> As far as I know, the tracing functionality in
> /sys/kernel/debug/tracing does not take advantage of ETM. ETM is a
> dedicated hardware that greatly reduces tracing overhead. It only
> exists on ARM platforms.

How much overhead does the existing tracing code have on ARM?  Is ETM
still even needed?  Why not just use ETM for the core tracing code
instead?

> I understand using sysfs here is not the cleanest way. I patched my
> kernel to meet my needs (trace a specific process or address range),
> and I thought these small modifications could be useful -- until
> bigger work is done to remove ETM control from sysfs.
> 
> Do you think it's worth correcting my patch (for pid namespaces) and
> re-submitting it? Or should we wait for someone to port ETM tracing to
> debugfs?

What's wrong with the in-kernel tracing logic that you can't use that
instead of the ETM stuff?

And no, I don't think adding more functionality to this will be good to
do, ideally it could just be dropped...

thanks,

greg k-h

  reply	other threads:[~2013-12-04 23:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04  4:39 [PATCH 0/3] ARM Coresight: Enhance ETM tracing control Adrien Vergé
2013-12-04  7:04 ` Greg Kroah-Hartman
2013-12-04 16:52   ` Adrien Vergé
2013-12-04 17:07     ` Greg Kroah-Hartman
2013-12-04 21:12       ` Adrien Vergé
2013-12-04 23:02         ` Greg Kroah-Hartman [this message]
2013-12-05  3:49           ` Adrien Vergé
2013-12-05  4:01             ` Greg Kroah-Hartman
2013-12-05 20:12               ` Christopher Covington
2013-12-05 20:16                 ` Greg Kroah-Hartman
2013-12-05 22:45                   ` Christopher Covington
2013-12-05 23:26                     ` Greg Kroah-Hartman
2013-12-05 23:54                     ` Adrien Vergé
2013-12-06  0:06                       ` Greg Kroah-Hartman
2013-12-06  0:23                         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131204230239.GB9205@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=adrienverge@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=dietmar.eggemann@arm.com \
    --cc=jovi.zhangwei@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rdunlap@infradead.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox