From: Greg KH <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next] mei: add 9 series PCH mei device ids
Date: Wed, 4 Dec 2013 20:19:13 -0800 [thread overview]
Message-ID: <20131205041913.GA4975@kroah.com> (raw)
In-Reply-To: <1386068489-19511-1-git-send-email-tomas.winkler@intel.com>
On Tue, Dec 03, 2013 at 01:01:29PM +0200, Tomas Winkler wrote:
> And Lynx Point H Refresh and Wildcat Point LP
> device ids.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/misc/mei/hw-me-regs.h | 4 ++++
> drivers/misc/mei/pci-me.c | 4 +++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h
> index 6c0fde5..f83bc80 100644
> --- a/drivers/misc/mei/hw-me-regs.h
> +++ b/drivers/misc/mei/hw-me-regs.h
> @@ -110,8 +110,12 @@
> #define MEI_DEV_ID_PPT_3 0x1DBA /* Panther Point */
>
> #define MEI_DEV_ID_LPT 0x8C3A /* Lynx Point */
> +#define MEI_DEV_ID_LPT_H 0x8C3A /* Lynx Point H */
Why duplicate this #define?
And, now that you changed it, why keep the "old" one around, it's no
longer used anywhere else?
thanks,
greg k-h
next prev parent reply other threads:[~2013-12-05 4:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 11:01 [char-misc-next] mei: add 9 series PCH mei device ids Tomas Winkler
2013-12-05 4:19 ` Greg KH [this message]
2013-12-05 7:34 ` Winkler, Tomas
-- strict thread matches above, loose matches on Subject: below --
2013-12-05 7:34 Tomas Winkler
2013-12-05 14:31 ` Greg KH
2013-12-05 16:50 ` Winkler, Tomas
2013-12-05 17:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205041913.GA4975@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox