From: Mark Brown <broonie@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: gpio: Don't require a regulator-type property
Date: Thu, 5 Dec 2013 11:35:31 +0000 [thread overview]
Message-ID: <20131205113531.GN29268@sirena.org.uk> (raw)
In-Reply-To: <1766701.HGqKkTj0sM@avalon>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Thu, Dec 05, 2013 at 01:44:42AM +0100, Laurent Pinchart wrote:
> On Thursday 05 December 2013 00:31:55 Mark Brown wrote:
> > + if (ret >= 0) {
> > + if (!strncmp("voltage", regtype, 7))
> > + config->type = REGULATOR_VOLTAGE;
> > + else if (!strncmp("current", regtype, 7))
> > + config->type = REGULATOR_CURRENT;
> Should we warn or error in case of an unsupported value ?
That's sensible, yes - this was just a straight change to make the
property optional. Given that we've always accepted anything a warning
seems more appropriate otherwise we might break existing DTs with typos
or something.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-05 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 0:31 [PATCH] regulator: gpio: Don't require a regulator-type property Mark Brown
2013-12-05 0:44 ` Laurent Pinchart
2013-12-05 11:35 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205113531.GN29268@sirena.org.uk \
--to=broonie@kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox