From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] perf trace: Fix crash on RHEL6
Date: Thu, 5 Dec 2013 10:09:24 -0300 [thread overview]
Message-ID: <20131205130924.GA10333@ghostprotocols.net> (raw)
In-Reply-To: <1386211302-31303-3-git-send-email-dsahern@gmail.com>
Em Wed, Dec 04, 2013 at 07:41:40PM -0700, David Ahern escreveu:
> Signed-off-by: David Ahern <dsahern@gmail.com>
What would make no fields to be present if tp_format is not NULL, i.e.
if the /format file was successfully parsed?
- Arnaldo
> ---
> tools/perf/builtin-trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index a7aa771a98e6..8f47eaae2f34 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1455,7 +1455,7 @@ static size_t syscall__scnprintf_args(struct syscall *sc, char *bf, size_t size,
> {
> size_t printed = 0;
>
> - if (sc->tp_format != NULL) {
> + if ((sc->tp_format != NULL) && (sc->tp_format->format.fields != NULL)) {
> struct format_field *field;
> u8 bit = 1;
> struct syscall_arg arg = {
> --
> 1.8.3.4 (Apple Git-47)
next prev parent reply other threads:[~2013-12-05 13:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 2:41 [PATCH 0/4] perf trace fixes David Ahern
2013-12-05 2:41 ` [PATCH 1/4] perf trace: Add support for syscalls vs raw_syscalls David Ahern
2013-12-11 11:03 ` [tip:perf/core] " tip-bot for David Ahern
2013-12-05 2:41 ` [PATCH 2/4] perf trace: Fix crash on RHEL6 David Ahern
2013-12-05 13:09 ` Arnaldo Carvalho de Melo [this message]
2013-12-05 14:27 ` David Ahern
2013-12-05 14:47 ` Arnaldo Carvalho de Melo
2013-12-05 2:41 ` [PATCH 3/4] perf trace: Fix summary percentage when processing files David Ahern
2013-12-11 11:03 ` [tip:perf/core] " tip-bot for David Ahern
2013-12-05 2:41 ` [PATCH 4/4] perf trace: Add option to specify machine type David Ahern
2013-12-05 13:50 ` Arnaldo Carvalho de Melo
2013-12-05 14:33 ` David Ahern
2013-12-05 14:49 ` Arnaldo Carvalho de Melo
2013-12-05 4:04 ` [PATCH 0/4] perf trace fixes David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205130924.GA10333@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox