From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@debian.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch] fix n900 bt error handling
Date: Thu, 5 Dec 2013 14:08:28 +0100 [thread overview]
Message-ID: <201312051408.30330@pali> (raw)
In-Reply-To: <20131205115608.GA9498@amd.pavel.ucw.cz>
[-- Attachment #1: Type: Text/Plain, Size: 1132 bytes --]
On Thursday 05 December 2013 12:56:08 Pavel Machek wrote:
> Hi!
>
> > I think that we can drop "new" version, because it has
> > several problems and "old" version is working. So now it
> > not make sense to use hack or develop "new" version
> > anymore.
>
> Ok... but this seems still needed. Please apply,
> Pavel
>
> commit 6c65774280a7095dce8b1e995d86b2e079ef5fdb
> Author: Pavel <pavel@ucw.cz>
> Date: Thu Dec 5 12:54:31 2013 +0100
>
> Cleanups should be performed even if firmware load fails.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/bluetooth/hci_h4p/core.c
> b/drivers/bluetooth/hci_h4p/core.c index ead25c4..e76e889
> 100644
> --- a/drivers/bluetooth/hci_h4p/core.c
> +++ b/drivers/bluetooth/hci_h4p/core.c
> @@ -942,7 +942,7 @@ again:
> err = hci_h4p_read_fw(info, &fw_queue);
> if (err < 0) {
> dev_err(info->dev, "Cannot read firmware\n");
> - return err;
> + goto err_clean;
> }
>
> err = hci_h4p_send_fw(info, &fw_queue);
Done, pushed to 3.12-rc5-n900 and 3.13-rc2-n900 branches.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2013-12-05 13:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 12:51 hci_h4p from linux-n900 branch: fix with new bluetooth for 3.13-rc1 Pavel Machek
2013-11-27 14:59 ` Pali Rohár
2013-11-27 19:13 ` Pavel Machek
2013-11-27 19:44 ` Pali Rohár
2013-11-29 23:58 ` Pali Rohár
2013-11-30 17:29 ` Pavel Machek
2013-11-30 23:15 ` device-tree based boot on linux-n900 branch Pavel Machek
2013-12-01 9:50 ` Pali Rohár
2013-12-01 10:24 ` Sebastian Reichel
2013-12-01 19:21 ` Compile failure on linux-n900 branch -- MEDIA_CAMERA_SUPPORT needed for n900 compilation Pavel Machek
2013-12-01 19:25 ` Pali Rohár
2013-12-01 20:01 ` Pavel Machek
2013-12-01 20:25 ` Pavel Machek
2013-12-01 20:36 ` Pali Rohár
2013-12-02 9:23 ` linux-n900: minor coding style fixes Pavel Machek
2013-12-01 20:29 ` Compile failure on linux-n900 branch -- MEDIA_CAMERA_SUPPORT needed for n900 compilation Pali Rohár
2013-12-01 10:48 ` hci_h4p from linux-n900 branch: fix with new bluetooth for 3.13-rc1 Sebastian Reichel
2013-12-01 11:16 ` Pali Rohár
2013-12-01 11:30 ` Sebastian Reichel
[not found] ` <201312021613.19521@pali>
[not found] ` <20131204122204.GA10262@amd.pavel.ucw.cz>
[not found] ` <201312041732.05400@pali>
2013-12-05 11:56 ` [patch] fix n900 bt error handling Pavel Machek
2013-12-05 13:08 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312051408.30330@pali \
--to=pali.rohar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sre@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox