* [char-misc-next] mei: add 9 series PCH mei device ids
@ 2013-12-05 7:34 Tomas Winkler
2013-12-05 14:31 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Tomas Winkler @ 2013-12-05 7:34 UTC (permalink / raw)
To: gregkh; +Cc: arnd, linux-kernel, Tomas Winkler
And Lynx Point H Refresh and Wildcat Point LP
device ids.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
V2: remove duplicated LPT entry
drivers/misc/mei/hw-me-regs.h | 5 ++++-
drivers/misc/mei/pci-me.c | 4 +++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h
index 6c0fde5..66f411a 100644
--- a/drivers/misc/mei/hw-me-regs.h
+++ b/drivers/misc/mei/hw-me-regs.h
@@ -109,9 +109,12 @@
#define MEI_DEV_ID_PPT_2 0x1CBA /* Panther Point */
#define MEI_DEV_ID_PPT_3 0x1DBA /* Panther Point */
-#define MEI_DEV_ID_LPT 0x8C3A /* Lynx Point */
+#define MEI_DEV_ID_LPT_H 0x8C3A /* Lynx Point H */
#define MEI_DEV_ID_LPT_W 0x8D3A /* Lynx Point - Wellsburg */
#define MEI_DEV_ID_LPT_LP 0x9C3A /* Lynx Point LP */
+#define MEI_DEV_ID_LPT_HR 0x8CBA /* Lynx Point H Refresh */
+
+#define MEI_DEV_ID_WPT_LP 0x9CBA /* Wildcat Point LP */
/*
* MEI HW Section
*/
diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index 3bfae38..7dfaa32 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -76,9 +76,11 @@ static DEFINE_PCI_DEVICE_TABLE(mei_me_pci_tbl) = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_PPT_1)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_PPT_2)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_PPT_3)},
- {PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT)},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_H)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_W)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_LP)},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_HR)},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_WPT_LP)},
/* required last entry */
{0, }
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [char-misc-next] mei: add 9 series PCH mei device ids
2013-12-05 7:34 [char-misc-next] mei: add 9 series PCH mei device ids Tomas Winkler
@ 2013-12-05 14:31 ` Greg KH
2013-12-05 16:50 ` Winkler, Tomas
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2013-12-05 14:31 UTC (permalink / raw)
To: Tomas Winkler; +Cc: arnd, linux-kernel
On Thu, Dec 05, 2013 at 09:34:44AM +0200, Tomas Winkler wrote:
> And Lynx Point H Refresh and Wildcat Point LP
> device ids.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> V2: remove duplicated LPT entry
>
> drivers/misc/mei/hw-me-regs.h | 5 ++++-
> drivers/misc/mei/pci-me.c | 4 +++-
> 2 files changed, 7 insertions(+), 2 deletions(-)
This should go into 3.13-final, right? What about -stable versions?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [char-misc-next] mei: add 9 series PCH mei device ids
2013-12-05 14:31 ` Greg KH
@ 2013-12-05 16:50 ` Winkler, Tomas
2013-12-05 17:46 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Winkler, Tomas @ 2013-12-05 16:50 UTC (permalink / raw)
To: Greg KH; +Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
> On Thu, Dec 05, 2013 at 09:34:44AM +0200, Tomas Winkler wrote:
> > And Lynx Point H Refresh and Wildcat Point LP
> > device ids.
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > ---
> > V2: remove duplicated LPT entry
> >
> > drivers/misc/mei/hw-me-regs.h | 5 ++++-
> > drivers/misc/mei/pci-me.c | 4 +++-
> > 2 files changed, 7 insertions(+), 2 deletions(-)
>
> This should go into 3.13-final, right? What about -stable versions?
Yes, this can go to stable as well. I need to dig bit in from which version this is relevant, I think 3.9 and up
I will resend with info.
Can you just clarify for me what is the policy here, is the support for new HW a stable candidate?
Thanks
Tomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [char-misc-next] mei: add 9 series PCH mei device ids
2013-12-05 16:50 ` Winkler, Tomas
@ 2013-12-05 17:46 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2013-12-05 17:46 UTC (permalink / raw)
To: Winkler, Tomas; +Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
On Thu, Dec 05, 2013 at 04:50:00PM +0000, Winkler, Tomas wrote:
>
>
> > On Thu, Dec 05, 2013 at 09:34:44AM +0200, Tomas Winkler wrote:
> > > And Lynx Point H Refresh and Wildcat Point LP
> > > device ids.
> > >
> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > > ---
> > > V2: remove duplicated LPT entry
> > >
> > > drivers/misc/mei/hw-me-regs.h | 5 ++++-
> > > drivers/misc/mei/pci-me.c | 4 +++-
> > > 2 files changed, 7 insertions(+), 2 deletions(-)
> >
> > This should go into 3.13-final, right? What about -stable versions?
>
> Yes, this can go to stable as well. I need to dig bit in from which
> version this is relevant, I think 3.9 and up
> I will resend with info.
> Can you just clarify for me what is the policy here, is the support
> for new HW a stable candidate?
Please read Documentation/stable_kernel_rules.txt for the stable rules.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [char-misc-next] mei: add 9 series PCH mei device ids
@ 2013-12-03 11:01 Tomas Winkler
2013-12-05 4:19 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Tomas Winkler @ 2013-12-03 11:01 UTC (permalink / raw)
To: gregkh; +Cc: arnd, linux-kernel, Tomas Winkler
And Lynx Point H Refresh and Wildcat Point LP
device ids.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/hw-me-regs.h | 4 ++++
drivers/misc/mei/pci-me.c | 4 +++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h
index 6c0fde5..f83bc80 100644
--- a/drivers/misc/mei/hw-me-regs.h
+++ b/drivers/misc/mei/hw-me-regs.h
@@ -110,8 +110,12 @@
#define MEI_DEV_ID_PPT_3 0x1DBA /* Panther Point */
#define MEI_DEV_ID_LPT 0x8C3A /* Lynx Point */
+#define MEI_DEV_ID_LPT_H 0x8C3A /* Lynx Point H */
#define MEI_DEV_ID_LPT_W 0x8D3A /* Lynx Point - Wellsburg */
#define MEI_DEV_ID_LPT_LP 0x9C3A /* Lynx Point LP */
+#define MEI_DEV_ID_LPT_HR 0x8CBA /* Lynx Point H Refresh */
+
+#define MEI_DEV_ID_WPT_LP 0x9CBA /* Wildcat Point LP */
/*
* MEI HW Section
*/
diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index 3bfae38..7dfaa32 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -76,9 +76,11 @@ static DEFINE_PCI_DEVICE_TABLE(mei_me_pci_tbl) = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_PPT_1)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_PPT_2)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_PPT_3)},
- {PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT)},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_H)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_W)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_LP)},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_LPT_HR)},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, MEI_DEV_ID_WPT_LP)},
/* required last entry */
{0, }
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [char-misc-next] mei: add 9 series PCH mei device ids
2013-12-03 11:01 Tomas Winkler
@ 2013-12-05 4:19 ` Greg KH
2013-12-05 7:34 ` Winkler, Tomas
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2013-12-05 4:19 UTC (permalink / raw)
To: Tomas Winkler; +Cc: arnd, linux-kernel
On Tue, Dec 03, 2013 at 01:01:29PM +0200, Tomas Winkler wrote:
> And Lynx Point H Refresh and Wildcat Point LP
> device ids.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/misc/mei/hw-me-regs.h | 4 ++++
> drivers/misc/mei/pci-me.c | 4 +++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h
> index 6c0fde5..f83bc80 100644
> --- a/drivers/misc/mei/hw-me-regs.h
> +++ b/drivers/misc/mei/hw-me-regs.h
> @@ -110,8 +110,12 @@
> #define MEI_DEV_ID_PPT_3 0x1DBA /* Panther Point */
>
> #define MEI_DEV_ID_LPT 0x8C3A /* Lynx Point */
> +#define MEI_DEV_ID_LPT_H 0x8C3A /* Lynx Point H */
Why duplicate this #define?
And, now that you changed it, why keep the "old" one around, it's no
longer used anywhere else?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [char-misc-next] mei: add 9 series PCH mei device ids
2013-12-05 4:19 ` Greg KH
@ 2013-12-05 7:34 ` Winkler, Tomas
0 siblings, 0 replies; 7+ messages in thread
From: Winkler, Tomas @ 2013-12-05 7:34 UTC (permalink / raw)
To: Greg KH; +Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
> >
> > diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h
> > index 6c0fde5..f83bc80 100644
> > --- a/drivers/misc/mei/hw-me-regs.h
> > +++ b/drivers/misc/mei/hw-me-regs.h
> > @@ -110,8 +110,12 @@
> > #define MEI_DEV_ID_PPT_3 0x1DBA /* Panther Point */
> >
> > #define MEI_DEV_ID_LPT 0x8C3A /* Lynx Point */
> > +#define MEI_DEV_ID_LPT_H 0x8C3A /* Lynx Point H */
>
> Why duplicate this #define?
> And, now that you changed it, why keep the "old" one around, it's no
> longer used anywhere else?
>
The correct name is LPT_H so I've just missed to remove the line, sending V2.
Thanks
Tomas
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-12-05 17:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-05 7:34 [char-misc-next] mei: add 9 series PCH mei device ids Tomas Winkler
2013-12-05 14:31 ` Greg KH
2013-12-05 16:50 ` Winkler, Tomas
2013-12-05 17:46 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2013-12-03 11:01 Tomas Winkler
2013-12-05 4:19 ` Greg KH
2013-12-05 7:34 ` Winkler, Tomas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox