From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755588Ab3LFPgO (ORCPT ); Fri, 6 Dec 2013 10:36:14 -0500 Received: from mail-ob0-f182.google.com ([209.85.214.182]:33243 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752670Ab3LFPgJ (ORCPT ); Fri, 6 Dec 2013 10:36:09 -0500 Date: Fri, 6 Dec 2013 15:36:02 +0000 From: Lee Jones To: Stefan Agner Cc: Thierry Reding , swarren@wwwdotorg.org, dev@lynxeye.de, lgirdwood@gmail.com, broonie@kernel.org, kai.poggensee@avionic-design.de, sameo@linux.intel.com, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/3] mfd: tps6586x: add version detection Message-ID: <20131206153602.GC23519@lee--X1> References: <7812fb79beac0a6a409090f43d129893f9f93b5b.1386333697.git.stefan@agner.ch> <20131206142605.GA32363@ulmo.nvidia.com> <5e063ab19c8fb9754216189c65d8f670@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5e063ab19c8fb9754216189c65d8f670@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Dec 2013, Stefan Agner wrote: > Am 2013-12-06 15:26, schrieb Thierry Reding: > > On Fri, Dec 06, 2013 at 01:51:45PM +0100, Stefan Agner wrote: > >> Use the VERSIONCRC to determine the exact device version. According to > >> the datasheet this register can be used as device identifier. The > >> identification is needed since some tps6586x regulators use a different > >> voltage table. > >> > >> Signed-off-by: Stefan Agner > >> --- > >> Changes since v4: > >> - Use variable named version instead of ret > >> > >> Changes since v2: > >> - Avoid moving devm_kzalloc > >> --- > >> drivers/mfd/tps6586x.c | 50 +++++++++++++++++++++++++++++++++++++------- > >> include/linux/mfd/tps6586x.h | 7 +++++++ > >> 2 files changed, 49 insertions(+), 8 deletions(-) > > > > I think I also already gave my Reviewed-by on both this and 2/3, neither > > of which changed significantly enough to warrant that to be dropped. In > > general it's fine to keep Reviewed-by and Acked-by as long as you're > > only changing minor things. > > > > Thierry > > Ok, sorry, didn't realize that is my job to pick them up when doing new > revisions. Lee, can you add this when you apply this patch? Will it's not legislation, but it does help us a great deal. > Reviewed-by: Thierry Reding Sure. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog