From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754809Ab3LFPgE (ORCPT ); Fri, 6 Dec 2013 10:36:04 -0500 Received: from kanga.kvack.org ([205.233.56.17]:37022 "EHLO kanga.kvack.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669Ab3LFPgD (ORCPT ); Fri, 6 Dec 2013 10:36:03 -0500 Date: Fri, 6 Dec 2013 10:36:03 -0500 From: Benjamin LaHaise To: Dave Jones , Gu Zheng , linux-aio@kvack.org, fsdevel , linux-kernel , Al Viro , Kent , Kristian Nielsen Subject: Re: [PATCH] aio: clean up aio ring in the fail path Message-ID: <20131206153603.GE13581@kvack.org> References: <529F019A.2040401@cn.fujitsu.com> <20131206152654.GD13581@kvack.org> <20131206153413.GA31613@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131206153413.GA31613@redhat.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 06, 2013 at 10:34:13AM -0500, Dave Jones wrote: > On Fri, Dec 06, 2013 at 10:26:54AM -0500, Benjamin LaHaise wrote: > > On Wed, Dec 04, 2013 at 06:19:06PM +0800, Gu Zheng wrote: > > > Clean up the aio ring file in the fail path of aio_setup_ring > > > and ioctx_alloc. And maybe it can fix the GPF issue reported by > > > Dave Jones: > > > https://lkml.org/lkml/2013/11/25/898 > > > > Good catch. I've applied this to my aio-next tree. It does indeed look > > like it could be the cause of Dave's GPF -- I'll try to trigger it with > > some other kernel debug options on and see if the EAGAIN failure case can > > trip it up. > > I think I forgot to reply and let you know this seems to fix it for me. Excellent! I'll send this out and get it queued up for -stable as well. -ben > Dave -- "Thought is the essence of where you are now."