From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757623Ab3LFPjM (ORCPT ); Fri, 6 Dec 2013 10:39:12 -0500 Received: from mail-oa0-f51.google.com ([209.85.219.51]:56059 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757464Ab3LFPjJ (ORCPT ); Fri, 6 Dec 2013 10:39:09 -0500 Date: Fri, 6 Dec 2013 15:39:03 +0000 From: Lee Jones To: Stefan Agner Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com, dev@lynxeye.de, lgirdwood@gmail.com, broonie@kernel.org, kai.poggensee@avionic-design.de, sameo@linux.intel.com, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/3] mfd: tps6586x: add version detection Message-ID: <20131206153903.GD23519@lee--X1> References: <7812fb79beac0a6a409090f43d129893f9f93b5b.1386333697.git.stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7812fb79beac0a6a409090f43d129893f9f93b5b.1386333697.git.stefan@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Dec 2013, Stefan Agner wrote: > Use the VERSIONCRC to determine the exact device version. According to > the datasheet this register can be used as device identifier. The > identification is needed since some tps6586x regulators use a different > voltage table. > > Signed-off-by: Stefan Agner > --- > Changes since v4: > - Use variable named version instead of ret > > Changes since v2: > - Avoid moving devm_kzalloc > --- > drivers/mfd/tps6586x.c | 50 +++++++++++++++++++++++++++++++++++++------- > include/linux/mfd/tps6586x.h | 7 +++++++ > 2 files changed, 49 insertions(+), 8 deletions(-) Applied with Acks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog