From: Lee Jones <lee.jones@linaro.org>
To: Stefan Agner <stefan@agner.ch>
Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com, dev@lynxeye.de,
lgirdwood@gmail.com, broonie@kernel.org,
kai.poggensee@avionic-design.de, sameo@linux.intel.com,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] regulator: tps6586x: add and use correct voltage table
Date: Fri, 6 Dec 2013 15:40:06 +0000 [thread overview]
Message-ID: <20131206154006.GE23519@lee--X1> (raw)
In-Reply-To: <7c948660cda4684d28fa97f82295ab84f6ef658e.1386333697.git.stefan@agner.ch>
On Fri, 06 Dec 2013, Stefan Agner wrote:
> Depending on the regulator version, the voltage table might be
> different. Use version specific regulator tables in order to select
> correct voltage table. For the following regulator versions different
> voltage tables are now used:
>
> * TPS658623: Use correct voltage table for SM2
> * TPS658643: New voltage table for SM2
>
> Both versions are in use on the Colibri T20 module. Make use of the
> correct tables by requesting the correct SM2 voltage of 1.8V.
>
> This change is not backward compatible since an old driver is not able
> to correctly set that value. The value 1.8V is out of range for the old
> driver and will refuse to probe the device. The regulator starts with
> default settings and the driver shows appropriate error messages.
>
> On Colibri T20, the old value used to work with TPS658623 since the
> driver applied a wrong voltage table too. However, the TPS658643 used
> on V1.2 devices uses yet another voltage table and those broke that
> pseudo-compatibility. The regulator driver now has the correct voltage
> table for both regulator versions and those the correct voltage can be
> used in the device tree.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Changes since v3:
> - Check if version specific table is necessary
>
> Changes since v2:
> - Removed reg_ from reg_version
> - Moved walk through version dependent tables to find_regulator_info,
> removed the inline definition. This reduces .o size and encapsulates
> the logic of finding the right regulator into one function. It comes
> with a slight code duplication, the table search now appears twice.
> ---
> arch/arm/boot/dts/tegra20-colibri-512.dtsi | 4 +-
> drivers/regulator/tps6586x-regulator.c | 93 ++++++++++++++++++++++++-----
Applied with Reviews and Acks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-12-06 15:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 12:51 [PATCH v5 0/3] regulator: tps6586x: add version detection and voltage tables Stefan Agner
2013-12-06 12:51 ` [PATCH v5 1/3] mfd: tps6586x: add version detection Stefan Agner
2013-12-06 14:26 ` Thierry Reding
2013-12-06 15:00 ` Stefan Agner
2013-12-06 15:36 ` Lee Jones
2013-12-06 15:34 ` Lee Jones
2013-12-06 15:39 ` Lee Jones
2013-12-06 17:48 ` Stephen Warren
[not found] ` <CAF2Aj3i95j+ZG4gmpSS9Hq6AKXj6w7mB1psYQwT6oas3QfNBrA@mail.gmail.com>
2013-12-06 20:31 ` Stephen Warren
2013-12-06 12:51 ` [PATCH v5 2/3] regulator: tps6586x: add and use correct voltage table Stefan Agner
2013-12-06 12:55 ` Mark Brown
2013-12-06 14:57 ` Stefan Agner
2013-12-06 15:40 ` Lee Jones [this message]
2013-12-06 12:51 ` [PATCH v5 3/3] ARM: tegra: correct Colibri T20 regulator settings Stefan Agner
2013-12-12 20:16 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206154006.GE23519@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=dev@lynxeye.de \
--cc=kai.poggensee@avionic-design.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=stefan@agner.ch \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox