From: Tejun Heo <tj@kernel.org>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: Li Zefan <lizefan@huawei.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
devel@openvz.org
Subject: Re: [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path
Date: Fri, 6 Dec 2013 11:25:03 -0500 [thread overview]
Message-ID: <20131206162503.GD13373@htj.dyndns.org> (raw)
In-Reply-To: <20131206161312.GC13373@htj.dyndns.org>
On Fri, Dec 06, 2013 at 11:13:12AM -0500, Tejun Heo wrote:
> > Second, it's not clear to me why we need the CSS_ONLINE flag at all if
> > we never assign css's that we fail to online to a cgroup. AFAIU we will
> > never see such css's, because in all places we call offline_css(),
> > namely cgroup_destroy_locked() (via kill_css()) and
> > cgroup_unload_subsys(), we use cgroup_css() which will return NULL for them.
>
> The whole thing is in flux and will look very different in near
> future. I actually had patches queued which deal with the issue you
> spotted but they are being blocked on other changes ATM. So, yeah,
> there are some spurious stuff now.
LOL, I found the patch. It was posted and acked I just forgot to
apply the whole series. I'm a moron.
http://permalink.gmane.org/gmane.linux.kernel.containers/26804
This should do it, right? I'll update the patch description and
repost the series.
Thanks!
--
tejun
next prev parent reply other threads:[~2013-12-06 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 9:00 [PATCH] cgroup: fix bug on cgroup_create() fail path Vladimir Davydov
2013-12-05 21:18 ` [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path Tejun Heo
2013-12-06 7:02 ` Vladimir Davydov
2013-12-06 16:13 ` Tejun Heo
2013-12-06 16:25 ` Tejun Heo [this message]
2013-12-06 18:04 ` Vladimir Davydov
2013-12-06 18:02 ` Vladimir Davydov
2013-12-09 9:10 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206162503.GD13373@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox