public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Mike Galbraith <bitbucket@online.de>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Andi Kleen <ak@linux.intel.com>,
	lenb@kernel.org, tglx@linutronix.de, peterz@infradead.org
Subject: Re: [PATCH] Trace idle entry and exit times
Date: Sat, 7 Dec 2013 06:20:29 +0100	[thread overview]
Message-ID: <20131207052029.GC21717@two.firstfloor.org> (raw)
In-Reply-To: <1386392252.5673.31.camel@marge.simpson.net>

On Sat, Dec 07, 2013 at 05:57:32AM +0100, Mike Galbraith wrote:
> On Fri, 2013-12-06 at 16:46 -0800, Andi Kleen wrote: 
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > This patch creates 4 new trace points: one at the beginning of idle,
> > one before entering mwait, one after exiting mwait, and one after
> > finishing the idle code. This is useful to trace down any
> > additional latencies caused by the ever-growing idle code.
> > 
> > Idle latencies are a common source of performance problems, so it's
> > important to be able to measure them.
> 
> You mean stuff like.. oh, say 60 cores doing zero work every 12ms
> munching ~20% cpu?

Well that one is obvious. I mean more the subtle problems.

BTW the timer problem is fixed on Westmere and later (always running APIC
timer), but yes it's a problem before that. I looked at it some time ago,
but eventually gave up after only fixing low hanging fruit. There are likely 
some more tricks that could be done here (see the old patches from back then)

-Andi

  reply	other threads:[~2013-12-07  5:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-07  0:46 [PATCH] Trace idle entry and exit times Andi Kleen
2013-12-07  4:57 ` Mike Galbraith
2013-12-07  5:20   ` Andi Kleen [this message]
2013-12-07  8:22     ` Mike Galbraith
2013-12-07 17:29       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131207052029.GC21717@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=bitbucket@online.de \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox