public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gary Rookard <garyrookard@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	lisa@xenapiadmin.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] Staging: bcm: DDRInit: replaced C99 comments.
Date: Sat, 7 Dec 2013 11:06:44 +0300	[thread overview]
Message-ID: <20131207080644.GL28413@mwanda> (raw)
In-Reply-To: <1386391955-11713-1-git-send-email-garyrookard@gmail.com>

On Fri, Dec 06, 2013 at 11:52:35PM -0500, Gary Rookard wrote:
> This is the fifth patch of a series.
> 
> Signed-off-by: Gary Alan Rookard <garyrookard@gmail.com>
> ---
> On branch staging-next
>  drivers/staging/bcm/DDRInit.c | 270 +++++++++++++++++++++---------------------
>  1 file changed, 135 insertions(+), 135 deletions(-)
> 
> diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
> index cb4dd53..1a08b17 100644
> --- a/drivers/staging/bcm/DDRInit.c
> +++ b/drivers/staging/bcm/DDRInit.c
> @@ -5,15 +5,15 @@
>  #define DDR_DUMP_INTERNAL_DEVICE_MEMORY 0xBFC02B00
>  #define MIPS_CLOCK_REG 	0x0f000820
>  
> -    //DDR INIT-133Mhz
> -#define T3_SKIP_CLOCK_PROGRAM_DUMP_133MHZ 12  //index for 0x0F007000
> -static struct bcm_ddr_setting asT3_DDRSetting133MHz[] = {//      # DPLL Clock Setting
> +    /* DDR INIT-133Mhz */
> +#define T3_SKIP_CLOCK_PROGRAM_DUMP_133MHZ 12  /* index for 0x0F00700 */0
                                                                        ^^^

This also breaks the build...  :(  Really, this is not ok.

regards,
dan carpenter


  reply	other threads:[~2013-12-07  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-07  4:52 [PATCH 5/9] Staging: bcm: DDRInit: replaced C99 comments Gary Rookard
2013-12-07  8:06 ` Dan Carpenter [this message]
2013-12-07  8:16 ` Levente Kurusa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131207080644.GL28413@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=garyrookard@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lisa@xenapiadmin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox