From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758532Ab3LGRKv (ORCPT ); Sat, 7 Dec 2013 12:10:51 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38172 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753464Ab3LGRKs (ORCPT ); Sat, 7 Dec 2013 12:10:48 -0500 Date: Sat, 7 Dec 2013 09:12:17 -0800 From: Greg Kroah-Hartman To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Thomas Hellstrom , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: serio - fix sysfs layout Message-ID: <20131207171217.GA19016@kroah.com> References: <20131207154116.GA9902@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131207154116.GA9902@core.coreip.homeip.net> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 07, 2013 at 07:41:19AM -0800, Dmitry Torokhov wrote: > Restore previous layout of sysfs attributes that was broken by commit > 3778a2129bcce84f684cc0017ed20d2524afd289 (input: serio: remove bus usage of > dev_attrs) which moved all serio device attributes into 'id' group, when > only 'type', 'proto', 'id', and 'extra' should be in 'id' group and the > rest of attributes should be attached directly to the device. Ick, sorry about that. > Reported-by: Thomas Hellstrom > Signed-off-by: Dmitry Torokhov Acked-by: Greg Kroah-Hartman