[PATCH] Staging: android: fix parantheses coding style issue in alarm-dev.c

[PATCH] Staging: android: fix parantheses coding style issue in alarm-dev.c

[Preetam D'Souza]

This patch fixes an unecessary return statement parantheses error
found in alarm-dev.c by the checkpatch.pl tool -- alarm-dev.c now has
no more errors/warnings!

Signed-off-by: Preetam D'Souza <preetamjdsouza@gmail.com>
---
 drivers/staging/android/alarm-dev.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c
index 647694f..ccf74ee 100644
--- a/drivers/staging/android/alarm-dev.c
+++ b/drivers/staging/android/alarm-dev.c
@@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
  */
 static int is_wakeup(enum android_alarm_type type)
 {
-	return (type == ANDROID_ALARM_RTC_WAKEUP ||
-		type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
+	return type == ANDROID_ALARM_RTC_WAKEUP ||
+		type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
 }
 
 
-- 
1.7.10.4

Re: [PATCH] Staging: android: fix parantheses coding style issue in alarm-dev.c

[Greg KH]

On Sat, Dec 07, 2013 at 02:35:52PM -0800, Preetam D'Souza wrote:
> This patch fixes an unecessary return statement parantheses error
> found in alarm-dev.c by the checkpatch.pl tool -- alarm-dev.c now has
> no more errors/warnings!
> 
> Signed-off-by: Preetam D'Souza <preetamjdsouza@gmail.com>
> ---
>  drivers/staging/android/alarm-dev.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This was already fixed a while ago, what tree are you working against?

sorry, I can't apply this again.

greg k-h

Re: [PATCH] Staging: android: fix parantheses coding style issue in alarm-dev.c

[Preetam D'Souza]

Hey Greg--I'm working against Linus' latest tree on
https://github.com/torvalds/linux.git ... which tree should I be using
for the updated code?

Thanks!
Preetam

On Sun, Dec 8, 2013 at 5:30 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Dec 07, 2013 at 02:35:52PM -0800, Preetam D'Souza wrote:
>> This patch fixes an unecessary return statement parantheses error
>> found in alarm-dev.c by the checkpatch.pl tool -- alarm-dev.c now has
>> no more errors/warnings!
>>
>> Signed-off-by: Preetam D'Souza <preetamjdsouza@gmail.com>
>> ---
>>  drivers/staging/android/alarm-dev.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> This was already fixed a while ago, what tree are you working against?
>
> sorry, I can't apply this again.
>
> greg k-h

Re: [PATCH] Staging: android: fix parantheses coding style issue in alarm-dev.c

[Greg KH]

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top


On Mon, Dec 09, 2013 at 07:53:19PM -0800, Preetam D'Souza wrote:
> Hey Greg--I'm working against Linus' latest tree on
> https://github.com/torvalds/linux.git ... which tree should I be using
> for the updated code?

linux-next or the subsystem-specific tree (for drivers/staging/ that
would be the staging.git tree at git.kernel.org, and use the
staging-next branch.)

hope this helps,

greg k-h

Re: [PATCH] Staging: android: fix parantheses coding style issue in alarm-dev.c

[Preetam D'Souza]

On Mon, Dec 9, 2013 at 8:04 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> linux-next or the subsystem-specific tree (for drivers/staging/ that
> would be the staging.git tree at git.kernel.org, and use the
> staging-next branch.)
>
> hope this helps,
>
> greg k-h

Got it! Thanks for the heads UP, will switch over to *-next.

-Preetam