From: Mark Brown <broonie@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
devicetree@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
linux-kernel@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Richard Weinberger <richard.weinberger@gmail.com>
Subject: Re: [rtc-linux] [PATCH v3 1/2] dt-bindings: add hym8563 binding
Date: Mon, 9 Dec 2013 11:14:21 +0000 [thread overview]
Message-ID: <20131209111421.GP29268@sirena.org.uk> (raw)
In-Reply-To: <201312071446.11997.heiko@sntech.de>
[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]
On Sat, Dec 07, 2013 at 02:46:11PM +0100, Heiko Stübner wrote:
> Am Montag, 2. Dezember 2013, 14:41:10 schrieb Mark Brown:
> > On Sun, Dec 01, 2013 at 08:47:42PM +0100, Heiko Stübner wrote:
> > > +Required properties:
> > > +- compatible: should be: "haoyu,hym8563"
> > > +- reg: i2c address
> > > +- gpios: alarm interrupt gpio
> > Why is this specified as a GPIO and not as an interrupt?
>
> sorry for the late reply, but it seems I got somehow droppen from your
> recipient list, so just found this mail on the mailinglist.
Your mail had reply to set on it.
> In v1 I specified the interrupt and the gpio. Apart from the resulting
> duplication of information this also resulted in the gpio only being requested
> but never used itself, which Mark Rutland did not seem to like this much :-) .
>
> As I'd like to keep the sanity check that really requesting the interrupt gpio
> always provided thru a gpio. As there are other drivers going this route it
> looked like an ok way to go.
> So what would be the real way to go? Specify only the interrupt, only the gpio
> or both?
Specify only the interrupt if it's genuinely an interrupt - requiring a
GPIO is broken as not all interrupt controllers are also GPIOs. There
are some OMAP drivers that are broken in this regard but they shouldn't
be doing that. Only use a GPIO specifier if it's used as a GPIO.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-09 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 19:47 [PATCH v3 0/2] Add support for hym8563 rtcs Heiko Stübner
2013-12-01 19:47 ` [PATCH v3 1/2] dt-bindings: add hym8563 binding Heiko Stübner
2013-12-02 13:41 ` [rtc-linux] " Mark Brown
2013-12-07 13:46 ` Heiko Stübner
2013-12-09 11:14 ` Mark Brown [this message]
2013-12-01 19:48 ` [PATCH v3 2/2] rtc: add hym8563 rtc-driver Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209111421.GP29268@sirena.org.uk \
--to=broonie@kernel.org \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=richard.weinberger@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox