From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932266Ab3LISl2 (ORCPT ); Mon, 9 Dec 2013 13:41:28 -0500 Received: from mail-qe0-f54.google.com ([209.85.128.54]:41601 "EHLO mail-qe0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755919Ab3LISl1 (ORCPT ); Mon, 9 Dec 2013 13:41:27 -0500 Date: Mon, 9 Dec 2013 15:41:19 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: Namhyung Kim , Frederic Weisbecker , Ingo Molnar , Jiri Olsa , LKML , Namhyung Kim Subject: Re: [PATCHSET 00/14] tools lib traceevent: Get rid of *die() calls from parse-filter.c Message-ID: <20131209184119.GD8098@ghostprotocols.net> References: <1386567251-22751-1-git-send-email-namhyung@kernel.org> <20131209112449.47eeedaa@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131209112449.47eeedaa@gandalf.local.home> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Dec 09, 2013 at 11:24:49AM -0500, Steven Rostedt escreveu: > On Mon, 9 Dec 2013 14:33:57 +0900 Namhyung Kim wrote: > > This patchset tries to remove all die() calls in event filter parsing > > code. The only remaining bits are in trace-seq.c which implement > > print functions and I want to hear what's the best way we can handle > > the error case during the print. > Other than what I commented on, the rest can have my: > Reviewed-by: Steven Rostedt Added this to all the ones I applied, Namhyung, please address the other concerns and check which ones were not applied so that you can have them in your next request. Thanks a lot! - Arnaldo