From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Olliver Schinagl <oliver+list@schinagl.nl>
Cc: oliver@schinagl.nl, tj@kernel.org, grant.likely@linaro.org,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dev@linux-sunxi.org,
ijc@hellion.org.uk, hdegoede@redhat.com
Subject: Re: [PATCH 3/3] ARM: sunxi: dts: Add ahci support to a few A10 and A20 boards
Date: Mon, 9 Dec 2013 20:16:20 +0100 [thread overview]
Message-ID: <20131209191620.GN24519@lukather> (raw)
In-Reply-To: <52A30ADB.7090106@schinagl.nl>
[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]
On Sat, Dec 07, 2013 at 12:47:39PM +0100, Olliver Schinagl wrote:
> Hey maxime,
> On 06-12-13 19:33, Maxime Ripard wrote:
> >Hi Oliver,
> >
> >On Wed, Dec 04, 2013 at 01:10:55PM +0100, oliver@schinagl.nl wrote:
> >>From: Oliver Schinagl <oliver@schinagl.nl>
> >>
> >>This patch adds sunxi sata support to A10 and A20 boards that have such
> >>a connector. Some boards also feature a regulator via a GPIO and support
> >>for this is also added.
> >>
> >>Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> >
> >Your git setup seems to be pretty uncertain about how your first name is spelled :)
> I should have formally mention it to confuse less people,
>
> This is how officially my name is spelled (I left out any 'middle'
> letters. I never really used it as such, as it confuses people and
> they always write it wrong anyway. After years I decided that at
> least on these patches, I should write it down properly
> (googleability etc in the future). So formally it's Olliver 'oliver'
> M. Schinagl.
>
> And no, I won't share my middle name :p
>
> There! :)
My point was more that the spelling in your From is different from the
spelling in your SoB.
> >>diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> >>index 0552a64..b72c69e 100644
> >>--- a/arch/arm/boot/dts/sun7i-a20.dtsi
> >>+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> >>@@ -368,6 +368,15 @@
> >> };
> >> };
> >>
> >>+ sata: ahci@01c18000 {
> >>+ compatible = "allwinner,sun4i-a10-ahci";
> >>+ reg = <0x01c18000 0x1000>;
> >>+ interrupts = <0 56 1>;
> Will always fix this to <0 56 4> if i'm not mistaken.
Only the GIC has a three-cells interrupts. So only the A20 and A31 are
supposed to have this value.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-09 19:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 12:10 [PATCH 0/3] AHCI: sunxi: Add sunxi AHCI driver oliver
2013-12-04 12:10 ` [PATCH 1/3] RFC: AHCI: libahci is missing DMA oliver
2013-12-04 12:32 ` Tejun Heo
2013-12-04 12:36 ` Oliver Schinagl
2013-12-04 12:47 ` Sergei Shtylyov
2013-12-04 13:09 ` Oliver Schinagl
2013-12-04 12:10 ` [PATCH 2/3] ARM: sunxi: Add an ahci-platform compatible AHCI driver for the Allwinner SUNXi series of SoCs oliver
2013-12-04 12:26 ` Mark Rutland
2013-12-04 12:49 ` Oliver Schinagl
2013-12-04 12:37 ` Tejun Heo
2013-12-04 12:56 ` Oliver Schinagl
2013-12-04 13:14 ` Tejun Heo
2013-12-04 13:16 ` Olliver Schinagl
2013-12-04 13:23 ` Tejun Heo
2013-12-06 9:01 ` Thomas Petazzoni
2013-12-06 9:12 ` Oliver Schinagl
2013-12-06 9:18 ` Thomas Petazzoni
2013-12-06 11:06 ` Hans de Goede
2013-12-15 19:00 ` Hans de Goede
2013-12-15 19:04 ` Tejun Heo
2013-12-16 6:21 ` Oliver Schinagl
2013-12-11 14:51 ` Olliver Schinagl
2013-12-12 6:40 ` Shawn Guo
2013-12-12 8:47 ` Olliver Schinagl
2013-12-04 12:10 ` [PATCH 3/3] ARM: sunxi: dts: Add ahci support to a few A10 and A20 boards oliver
2013-12-06 18:33 ` Maxime Ripard
2013-12-07 11:47 ` Olliver Schinagl
2013-12-07 13:11 ` [linux-sunxi] " Michal Suchanek
2013-12-09 19:16 ` Maxime Ripard [this message]
2013-12-04 12:14 ` [PATCH 0/3] AHCI: sunxi: Add sunxi AHCI driver Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209191620.GN24519@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=dev@linux-sunxi.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=hdegoede@redhat.com \
--cc=ijc@hellion.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver+list@schinagl.nl \
--cc=oliver@schinagl.nl \
--cc=rob.herring@calxeda.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox