From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753425Ab3LJJCi (ORCPT ); Tue, 10 Dec 2013 04:02:38 -0500 Received: from mail-yh0-f54.google.com ([209.85.213.54]:54858 "EHLO mail-yh0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752376Ab3LJJCd (ORCPT ); Tue, 10 Dec 2013 04:02:33 -0500 Date: Tue, 10 Dec 2013 09:02:29 +0000 From: Lee Jones To: Felipe Balbi Cc: Tony Lindgren , Aaro Koskinen , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH v3 10/15] mfd: menelaus: Pass menelaus_chip argument to menelaus <-> time helpers Message-ID: <20131210090229.GS12675@lee--X1> References: <20131209161422.GC24047@saruman.home> <1386606085-26838-1-git-send-email-balbi@ti.com> <1386606085-26838-10-git-send-email-balbi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1386606085-26838-10-git-send-email-balbi@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 09 Dec 2013, Felipe Balbi wrote: > time_to_menelaus() and menelaus_to_time() are static and can easily > receive a struct menelaus_chip pointer argument. > > After this patch, the_menelaus is only used on exported functions which > are currently being used by board-n8x0.c. > > Tested-by: Aaro Koskinen > Signed-off-by: Felipe Balbi > --- > drivers/mfd/menelaus.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) Same. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog