From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754920Ab3LJJcY (ORCPT ); Tue, 10 Dec 2013 04:32:24 -0500 Received: from mail-yh0-f49.google.com ([209.85.213.49]:64493 "EHLO mail-yh0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754046Ab3LJJcS (ORCPT ); Tue, 10 Dec 2013 04:32:18 -0500 Date: Tue, 10 Dec 2013 09:32:13 +0000 From: Lee Jones To: Felipe Balbi Cc: Tony Lindgren , Aaro Koskinen , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH v3 03/15] mfd: menelaus: Convert to threaded irq Message-ID: <20131210093213.GV12675@lee--X1> References: <20131209161422.GC24047@saruman.home> <1386606085-26838-1-git-send-email-balbi@ti.com> <1386606085-26838-3-git-send-email-balbi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1386606085-26838-3-git-send-email-balbi@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 09 Dec 2013, Felipe Balbi wrote: > We don't need that extra workqueue when we have generic threaded irq > handlers support. This patch just moves over to threaded irqs and > deletes the unnecessary workqueue. > > Tested-by: Aaro Koskinen > Signed-off-by: Felipe Balbi > --- > drivers/mfd/menelaus.c | 29 ++++------------------------- > 1 file changed, 4 insertions(+), 25 deletions(-) > - err = request_irq(client->irq, menelaus_irq, 0, > - DRIVER_NAME, menelaus); > + err = request_threaded_irq(client->irq, NULL, menelaus_irq, > + IRQF_ONESHOT, DRIVER_NAME, menelaus); devm_* managed resources please. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog