From: Ingo Molnar <mingo@kernel.org>
To: Jean Pihet <jean.pihet@linaro.org>
Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
Jiri Olsa <jolsa@redhat.com>, Arnaldo <acme@ghostprotocols.net>,
patches@linaro.org, Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v4 0/2] perf: config: add per-feature check flags
Date: Tue, 10 Dec 2013 13:26:00 +0100 [thread overview]
Message-ID: <20131210122600.GB30891@gmail.com> (raw)
In-Reply-To: <1386678244-13535-1-git-send-email-jean.pihet@linaro.org>
* Jean Pihet <jean.pihet@linaro.org> wrote:
> Add CFLAGS and LDFLAGS for each feature to be checked during the
> build. This allows to pass particular flags and parameters to the
> feature checks compilation.
>
> Use the per-feature check flags for the unwinding feature in order
> to correctly compile the test-all, libunwind and libunwind-debug-frame
> feature checks.
>
> This change set simplifies the flags passing mechanism between the
> Makefiles in config/Makefile and config/feature-checks; this
> could be farther optimized by moving the compilation flags to the
> per-feature check flags for all features to be checked.
>
> Tested on x86_64, ARMv7 and ARMv8 with and without LIBUNWIND_DIR
> set in 'make -C tools/perf'
>
>
> Jean Pihet (2):
> perf: add per-feature check flags
> perf: unwinding: use the per-feature check flags
>
> tools/perf/config/Makefile | 52 ++++++++++++++++++-------------
> tools/perf/config/feature-checks/Makefile | 8 ++---
> 2 files changed, 34 insertions(+), 26 deletions(-)
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2013-12-10 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 12:24 [PATCH v4 0/2] perf: config: add per-feature check flags Jean Pihet
2013-12-10 12:24 ` [PATCH 1/2] perf: " Jean Pihet
2013-12-11 11:08 ` [tip:perf/core] perf tools: Add " tip-bot for Jean Pihet
2013-12-10 12:24 ` [PATCH 2/2] perf: unwinding: use the " Jean Pihet
2013-12-11 11:08 ` [tip:perf/core] perf unwinding: Use " tip-bot for Jean Pihet
2013-12-10 12:26 ` Ingo Molnar [this message]
2013-12-10 13:36 ` [PATCH v4 0/2] perf: config: add " Jiri Olsa
2013-12-10 13:55 ` [PATCH 1/2] perf tools: Automate setup of FEATURE_CHECK_(C|LD)FLAGS-all variables Jiri Olsa
2013-12-10 15:55 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210122600.GB30891@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=jean.pihet@linaro.org \
--cc=jolsa@redhat.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox