public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Rik van Riel <riel@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Garrett <matthew.garrett@nebula.com>,
	Rob Landley <rob@landley.net>,
	Eric Biederman <ebiederm@xmission.com>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Mel Gorman <mgorman@suse.de>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	kexec@lists.infradead.org
Subject: Re: [PATCH v2] kexec: add sysctl to disable kexec
Date: Tue, 10 Dec 2013 09:38:28 -0500	[thread overview]
Message-ID: <20131210143828.GB13909@redhat.com> (raw)
In-Reply-To: <20131210143540.GA13909@redhat.com>

On Tue, Dec 10, 2013 at 09:35:40AM -0500, Vivek Goyal wrote:
> On Mon, Dec 09, 2013 at 05:06:10PM -0800, Kees Cook wrote:
> > On Mon, Dec 9, 2013 at 4:34 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> > > On 12/09/2013 04:16 PM, Kees Cook wrote:
> > >> For general-purpose (i.e. distro) kernel builds it makes sense to build with
> > >> CONFIG_KEXEC to allow end users to choose what kind of things they want to do
> > >> with kexec. However, in the face of trying to lock down a system with such
> > >> a kernel, there needs to be a way to disable kexec (much like module loading
> > >> can be disabled). Without this, it is too easy for the root user to modify
> > >> kernel memory even when CONFIG_STRICT_DEVMEM and modules_disabled are set.
> > >>
> > >> Signed-off-by: Kees Cook <keescook@chromium.org>
> > >> Acked-by: Rik van Riel <riel@redhat.com>
> > >
> > > So the logic is to load a crashkernel and then lock down the machine
> > > before services, networking etc. are enabled?
> > 
> > Right, or to just turn it off at boot time if kexec will not be used at all.
> 
> kdump kernel is loaded with the help of kdump service. Different distro's
> might have different dependencies for that serivce. But recently in fedora
> we wait network to come up before starting that service. (So that nfs
> targets can be mounted and checked for valid dump destinations).
> 
> IOW, crash kernel is loaded quite late in the game (quite a few services
> have run and possibly networking is up too). To me, practically one will
> disable kdump also if you change state of this knob early.

Of course it also removes the possibility of re-loading crash kernel
after doing some changes to /etc/kdump.conf (like dump destination or
kernel command line).

I am wondering if it is sufficient to disable kexec jump back
functionality only while retaining kexec and kdump. That seems to be
easiest way to change kernel's data structures.

Thanks
Vivek

  reply	other threads:[~2013-12-10 14:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10  0:16 [PATCH v2] kexec: add sysctl to disable kexec Kees Cook
2013-12-10  0:34 ` H. Peter Anvin
2013-12-10  1:06   ` Kees Cook
2013-12-10 14:35     ` Vivek Goyal
2013-12-10 14:38       ` Vivek Goyal [this message]
2013-12-10 16:32       ` H. Peter Anvin
2013-12-10 18:33         ` Vivek Goyal
2013-12-10 18:54           ` H. Peter Anvin
2013-12-10 19:14             ` Vivek Goyal
2013-12-10 19:33               ` Kees Cook
2013-12-11 17:52 ` Eric W. Biederman
2013-12-11 21:13   ` Kees Cook
2013-12-11 23:15     ` Eric W. Biederman
2013-12-11 23:22       ` Kees Cook
2013-12-12  1:14         ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131210143828.GB13909@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox