From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Axel Lin <axel.lin@ingics.com>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] clocksource: time-efm32: Select CLKSRC_MMIO
Date: Tue, 10 Dec 2013 17:05:48 +0100 [thread overview]
Message-ID: <20131210160548.GC18888@pengutronix.de> (raw)
In-Reply-To: <52A71746.6080809@linaro.org>
Hello Daniel,
On Tue, Dec 10, 2013 at 02:29:42PM +0100, Daniel Lezcano wrote:
> On 12/10/2013 02:24 PM, Uwe Kleine-König wrote:
> >On Wed, Nov 20, 2013 at 10:15:11AM +0800, Axel Lin wrote:
> >>The time-efm32 driver uses the clocksource MMIO functions.
> >>Thus it needs to select CLKSRC_MMIO in Kconfig.
> >>
> >>Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >>---
> >>This fixes build error when COMPILE_TEST=y.
> >>drivers/built-in.o: In function `efm32_clocksource_init':
> >>drivers/clocksource/time-efm32.c:162: undefined reference to `clocksource_mmio_init'
> >>drivers/built-in.o: In function `efm32_timer_init':
> >>drivers/clocksource/time-efm32.c:274: undefined reference to `clocksource_mmio_readl_up'
> >>make: *** [vmlinux] Error 1
> >>
> >> drivers/clocksource/Kconfig | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >>diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> >>index bdb953e..99763eb 100644
> >>--- a/drivers/clocksource/Kconfig
> >>+++ b/drivers/clocksource/Kconfig
> >>@@ -75,6 +75,7 @@ config CLKSRC_DBX500_PRCMU_SCHED_CLOCK
> >> config CLKSRC_EFM32
> >> bool "Clocksource for Energy Micro's EFM32 SoCs" if !ARCH_EFM32
> >> depends on OF && ARM && (ARCH_EFM32 || COMPILE_TEST)
> >>+ select CLKSRC_MMIO
> >> default ARCH_EFM32
> >I'd like to send support for arch/arm/mach-efm32 for 3.14. Formerly I
> >had ARCH_EFM32 select CLKSRC_MMIO, but having it here is obviously the
> >correct thing to do. So my possibilities are:
> >
> > a) I take this patch and apply mach-efm32 on top of it; or
> > b) you take it early enough for me into 3.13-rc to base mach-efm32 on
> > it; or
>
> I sent the PR with this patch. If everything is ok, it should be in
> the next -rc.
ok. Thanks for your quick reply.
It would be great if your tree were included in linux-next. Don't you
think this is feasible?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2013-12-10 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 2:15 [PATCH] clocksource: time-efm32: Select CLKSRC_MMIO Axel Lin
2013-11-20 9:22 ` Uwe Kleine-König
2013-12-10 13:24 ` Uwe Kleine-König
2013-12-10 13:29 ` Daniel Lezcano
2013-12-10 16:05 ` Uwe Kleine-König [this message]
2013-12-16 20:08 ` Daniel Lezcano
2013-12-16 20:54 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210160548.GC18888@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=axel.lin@ingics.com \
--cc=daniel.lezcano@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox