Re: [PATCH v2 4/4] futex: Avoid taking hb lock if nothing to wakeup

Ingo Molnar
2013-12-10T18:28:56Z

* Davidlohr Bueso <davidlohr@hp.com> wrote:

> On Tue, 2013-12-10 at 16:36 +0100, Ingo Molnar wrote:
> > * Davidlohr Bueso <davidlohr@hp.com> wrote:
> >
> > > On Fri, 2013-12-06 at 19:26 +0100, Thomas Gleixner wrote:
> > > > On Tue, 3 Dec 2013, Davidlohr Bueso wrote:
> > > > > Signed-off-by: Waiman Long <Waiman.Long@hp.com>
> > > > > Signed-off-by: Jason Low <jason.low2@hp.com>
> > > > > Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
> > > >
> > > > Who is the author of this? According to the SOB chains its Waiman, who
> > > > handed it down to Jason and it finally got sumbitted by you. Is that
> > > > correct?
> > >
> > > This was a group effort for the original patchset -- things did change
> > > quite a bit for this particular patch in v2. Waiman and Jason helped
> > > review and test the original atomic ops code.
> >
> > Then please put that into the credits (in the changelog and/or in the
> > source code), and/or into copyright notices, etc. - but keep the
> > SOB-chain the true route of the patch, where the primary author is the
> > first in the SOB and where the person sending the patch is the last
> > SOB. (the two are identical normally.)
>
> Ok, I wasn't aware of that primary author rule, sorry. The exact
> same thing would go for patch 2 then. Is this something you want me
> to correct for this particular series, or to keep in mind for the
> future?

Would be nice to fix it, the SOB chain is important for fine print
reasons.

Thanks,

Ingo