From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751621Ab3LJUv1 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Dec 2013 15:51:27 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:39749 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751451Ab3LJUvZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Dec 2013 15:51:25 -0500
Date: Tue, 10 Dec 2013 11:27:02 -0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heiko =?iso-8859-1?Q?St=FCbner?= <heiko@sntech.de>
Cc: Pavel Machek <pavel@ucw.cz>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, Laxman Dewangan <ldewangan@nvidia.com>,
        ian.campbell@citrix.com, rjw@rjwysocki.net, len.brown@intel.com,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3.12 46/62] irq: Enable all irqs unconditionally in
 irq_resume
Message-ID: <20131210192702.GC8075@kroah.com>
References: <20131210080057.415644748@linuxfoundation.org>
 <20131210090113.GA22756@amd.pavel.ucw.cz>
 <20131210090847.GA4600@kroah.com>
 <201312101352.53714.heiko@sntech.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <201312101352.53714.heiko@sntech.de>
User-Agent: Mutt/1.5.22 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 10, 2013 at 01:52:53PM +0100, Heiko Stübner wrote:
> Am Dienstag, 10. Dezember 2013, 10:08:47 schrieb Greg Kroah-Hartman:
> > On Tue, Dec 10, 2013 at 10:01:13AM +0100, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > 3.12-stable review patch.  If anyone has any objections, please let
> > > > 
> > > >  me know.
> > > 
> > > Objections... well... I'm not sure if it meets stable criteria. In
> > > particular, I don't think it was ever demonstrated as having bad
> > > effect on the users.
> > 
> > Well, I'm guessing someone on the cc: here wanted it in stable@, so I'll
> > let them speak up as to why...
> 
> As for bad effects on users ... any suspend_noirq callback returning an error 
> and thus aborting the suspend will cause the error fixed by this, as the 
> early-irqs won't get reenabled in the suspend-rollback [due to the syscore_ops 
> doing their resume never being run].
> 
> You could for example lose keys connected thru the gpio-keys driver until the 
> next reboot.
> 
> And it seems at least Laxman and myself were affected by it.

So, to be clear, this patch fixes a problem on your machines, right?

thanks,

greg k-h