From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-kernel@vger.kernel.org, Lai Siyao <laisiyao@whamcloud.com>,
Lai Siyao <lai.siyao@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>
Subject: Re: [PATCH 06/13] staging/lustre/llite: remove ll_d_root_ops
Date: Tue, 10 Dec 2013 18:32:38 -0800 [thread overview]
Message-ID: <20131211023238.GA10365@kroah.com> (raw)
In-Reply-To: <1386601025-422-7-git-send-email-bergwolf@gmail.com>
On Mon, Dec 09, 2013 at 10:56:58PM +0800, Peng Tao wrote:
> From: Lai Siyao <laisiyao@whamcloud.com>
>
> Mnt root dentry will never be revalidated, but its d_op->d_compare
> will be called for its children, to simplify code, we use the same
> ll_d_ops as normal dentries.
> But its attribute may be invalid before access, this won't cause
> any issue because it always exists, and the only operation depends
> on its attribute is .permission, which has revalidated it in lustre
> code.
>
> So it's okay to remove ll_d_root_ops, and remove unnecessary checks
> in lookup/revalidate/statahead.
This breaks the build.
It's as if you aren't testing this.
I'm really tired of this, I really don't want to take any more patches
from you for a while, as I dread them every time I see a series sent by
you for this codebase.
ugh.
next prev parent reply other threads:[~2013-12-11 2:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 14:56 [PATCH 00/13] staging/lustre: sync with external tree, set 3 Peng Tao
2013-12-09 14:56 ` [PATCH 01/13] staging/lustre: remove server macros from lustre_net.h Peng Tao
2013-12-09 14:56 ` [PATCH 02/13] staging/lustre/lnet: Add LNet Router Priority parameter Peng Tao
2013-12-09 14:56 ` [PATCH 03/13] staging/lustre/api: HSM import uses new released pattern Peng Tao
2013-12-09 14:56 ` [PATCH 04/13] staging/lustre/target: move OUT to the unified target code Peng Tao
2013-12-09 14:56 ` [PATCH 05/13] staging/lustre/seq: remove seq_{query,handle} Peng Tao
2013-12-09 14:56 ` [PATCH 06/13] staging/lustre/llite: remove ll_d_root_ops Peng Tao
2013-12-11 2:32 ` Greg Kroah-Hartman [this message]
2013-12-11 3:23 ` Peng Tao
2013-12-09 14:56 ` [PATCH 07/13] staging/lustre/llite: don't d_add for create only files Peng Tao
2013-12-09 14:57 ` [PATCH 08/13] staging/lustre/llite: pass correct pointer to obd_iocontrol() Peng Tao
2013-12-09 14:57 ` [PATCH 09/13] staging/lustre/idl: remove LASSERT/CLASSERT from lustre_idl.h Peng Tao
2013-12-09 14:57 ` [PATCH 10/13] staging/lustre/mgs: set_param -P option that sets value permanently Peng Tao
2013-12-09 14:57 ` [PATCH 11/13] staging/lustre/obdclass: remove extra break in class_process_config Peng Tao
2013-12-09 14:57 ` [PATCH 12/13] staging/lustre/lustre_user.h: remove obsolete comments Peng Tao
2013-12-09 14:57 ` [PATCH 13/13] staging/lustre/ptlrpc: flock deadlock detection does not work Peng Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211023238.GA10365@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=lai.siyao@intel.com \
--cc=laisiyao@whamcloud.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox