From: Al Viro <viro@ZenIV.linux.org.uk>
To: Antonio Quartulli <antonio@meshcoding.com>
Cc: Joe Perches <joe@perches.com>, Kees Cook <keescook@chromium.org>,
netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH -next 2/3] batman-adv: Use seq_overflow
Date: Wed, 11 Dec 2013 07:58:52 +0000 [thread overview]
Message-ID: <20131211075852.GS10323@ZenIV.linux.org.uk> (raw)
In-Reply-To: <52A814D7.1060805@meshcoding.com>
On Wed, Dec 11, 2013 at 08:31:35AM +0100, Antonio Quartulli wrote:
> Joe,
>
> we have other places in the batman-adv code where we use seq_printf, but
> at the moment we don't check the return value and we always return 0 at
> the end of the function.
>
> I think we could use seq_overflow here as well?
Not if you want correctly behaving code...
next prev parent reply other threads:[~2013-12-11 7:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 5:12 [PATCH -next 0/3] seq_printf/puts/putc: Start to convert to return void Joe Perches
2013-12-11 5:12 ` [PATCH -next 1/3] seq: Add a seq_overflow test Joe Perches
2013-12-11 23:27 ` Ryan Mallon
2013-12-11 23:31 ` Joe Perches
2013-12-11 5:12 ` [PATCH -next 2/3] batman-adv: Use seq_overflow Joe Perches
2013-12-11 7:26 ` Antonio Quartulli
2013-12-11 7:31 ` [B.A.T.M.A.N.] " Antonio Quartulli
2013-12-11 7:58 ` Al Viro [this message]
2013-12-11 7:55 ` Al Viro
2013-12-11 8:05 ` Al Viro
2013-12-11 8:26 ` Joe Perches
2013-12-11 8:38 ` Al Viro
2013-12-11 5:12 ` [PATCH -next 3/3] netfilter: " Joe Perches
2013-12-11 8:17 ` Al Viro
2013-12-11 5:20 ` [PATCH -next 0/3] seq_printf/puts/putc: Start to convert to return void David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211075852.GS10323@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).