From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751348Ab3LKJgA (ORCPT ); Wed, 11 Dec 2013 04:36:00 -0500 Received: from mail-yh0-f50.google.com ([209.85.213.50]:34586 "EHLO mail-yh0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774Ab3LKJf5 (ORCPT ); Wed, 11 Dec 2013 04:35:57 -0500 Date: Wed, 11 Dec 2013 09:35:52 +0000 From: Lee Jones To: Stephen Boyd Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/8] mfd: Move pm8xxx-irq.c contents into only driver that uses it Message-ID: <20131211093552.GG16780@lee--X1> References: <1386718523-2587-1-git-send-email-sboyd@codeaurora.org> <1386718523-2587-6-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1386718523-2587-6-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Dec 2013, Stephen Boyd wrote: > The pm8xxx-irq.c code is practically mandatory given that the > pm8921-core driver will WARN about it missing and the Kconfig > marks it as default y when a PM8xxx chips is enabled. The only > reason the file was split out was because we planned to support > other pm8xxx chips with different pm8xxx-core.c files. Now that > we have DT on ARM this isn't necessary because we should be able > to support all the ssbi based PM8xxx chips in one driver and one > file with no data bloat. Let's move this code into the only > driver that uses it right now (pm8921) so that it's always compiled when > needed. In the future we can rename pm8921-core.c to something > more generic. > > Signed-off-by: Stephen Boyd > --- > drivers/mfd/Kconfig | 10 -- > drivers/mfd/pm8921-core.c | 349 +++++++++++++++++++++++++++++++++++++++++++ > drivers/mfd/pm8xxx-irq.c | 371 ---------------------------------------------- If you're going to take this approach (which I'm fine with unless there are likely to be anymore incarnations of pm8xxx chips?), I think you should also clean-up the header in this patch. include/linux/mfd/pm8xxx/irq.h -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog