public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "José Miguel Gonçalves" <jose.goncalves@inov.pt>
Cc: Jean Delvare <khali@linux-fr.org>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: HIH-6130: Support I2C bus drivers without I2C_FUNC_SMBUS_QUICK
Date: Wed, 11 Dec 2013 13:28:35 -0800	[thread overview]
Message-ID: <20131211212835.GA23938@roeck-us.net> (raw)
In-Reply-To: <52A8C25A.6000403@inov.pt>

On Wed, Dec 11, 2013 at 07:51:54PM +0000, José Miguel Gonçalves wrote:
> On 11-12-2013 19:29, Guenter Roeck wrote:
> >On Wed, Dec 11, 2013 at 11:11:13AM +0000, José Miguel Gonçalves wrote:
> >>Some I2C bus drivers do not allow zero-length data transfers which are
> >>required to start a measurement with the HIH6130/1 sensor. Nevertheless,
> >>we can overcome this limitation by writing a zero dummy byte. This byte
> >>is ignored by the sensor and was verified to be working with the OMAP
> >>I2C bus driver in a BeagleBone board.
> >>
> >>Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
> >Applied, after simplifying write_length initialization a bit.
> >
> >Should this go to -stable ?
> 
> Any BeagleBone user that tries to use this sensor will encounter
> this issue. As this board is very popular, this will potentially
> solve the problems of many users. Nevertheless, it does not seems to
> me that this patch fixes "something critical", which is one of the
> conditions to be accepted in the -stable tree.
> 
Depends on the definition of "critical".

Guenter

  reply	other threads:[~2013-12-11 21:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11 11:11 [PATCH] hwmon: HIH-6130: Support I2C bus drivers without I2C_FUNC_SMBUS_QUICK José Miguel Gonçalves
2013-12-11 19:29 ` Guenter Roeck
2013-12-11 19:51   ` José Miguel Gonçalves
2013-12-11 21:28     ` Guenter Roeck [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-12-11  0:57 José Miguel Gonçalves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131211212835.GA23938@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jose.goncalves@inov.pt \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox