From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751859Ab3LKV2m (ORCPT ); Wed, 11 Dec 2013 16:28:42 -0500 Received: from mail-pd0-f174.google.com ([209.85.192.174]:37587 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041Ab3LKV2h (ORCPT ); Wed, 11 Dec 2013 16:28:37 -0500 Date: Wed, 11 Dec 2013 13:28:35 -0800 From: Guenter Roeck To: =?iso-8859-1?Q?Jos=E9_Miguel_Gon=E7alves?= Cc: Jean Delvare , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: HIH-6130: Support I2C bus drivers without I2C_FUNC_SMBUS_QUICK Message-ID: <20131211212835.GA23938@roeck-us.net> References: <1386760273-7703-1-git-send-email-jose.goncalves@inov.pt> <20131211192954.GA21751@roeck-us.net> <52A8C25A.6000403@inov.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <52A8C25A.6000403@inov.pt> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2013 at 07:51:54PM +0000, José Miguel Gonçalves wrote: > On 11-12-2013 19:29, Guenter Roeck wrote: > >On Wed, Dec 11, 2013 at 11:11:13AM +0000, José Miguel Gonçalves wrote: > >>Some I2C bus drivers do not allow zero-length data transfers which are > >>required to start a measurement with the HIH6130/1 sensor. Nevertheless, > >>we can overcome this limitation by writing a zero dummy byte. This byte > >>is ignored by the sensor and was verified to be working with the OMAP > >>I2C bus driver in a BeagleBone board. > >> > >>Signed-off-by: José Miguel Gonçalves > >Applied, after simplifying write_length initialization a bit. > > > >Should this go to -stable ? > > Any BeagleBone user that tries to use this sensor will encounter > this issue. As this board is very popular, this will potentially > solve the problems of many users. Nevertheless, it does not seems to > me that this patch fixes "something critical", which is one of the > conditions to be accepted in the -stable tree. > Depends on the definition of "critical". Guenter