From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com,
edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com,
sbw@mit.edu, oleg@redhat.com
Subject: [PATCH v6 tip/core/locking] Memory-barrier documentation updates + smp_mb__after_unlock_lock()
Date: Wed, 11 Dec 2013 13:58:50 -0800 [thread overview]
Message-ID: <20131211215850.GA810@linux.vnet.ibm.com> (raw)
Hello!
This series applies some long-needed updates to memory-barriers.txt and
adds an smp_mb__after_unlock_lock():
1. Add ACCESS_ONCE() calls where needed to ensure their inclusion
in code copy-and-pasted from this file.
2. Add long atomic examples alongside the existing atomics.
3. Prohibit architectures supporting the Linux kernel from
speculating stores.
4. Document what ACCESS_ONCE() does along with a number of situations
requiring its use.
5. Added smp_mb__after_unlock_lock() for all architectures. Because
all architectures are presumably providing full-barrier semantics
for UNLOCK+LOCK, these are all no-ops (but see #8 below). Some
will change if low-latency-handoff queued locks are accepted.
6. Downgrade UNLOCK+LOCK to no longer imply a full barrier, at least
in the absence of smp_mb__after_unlock_lock(). See the LKML thread
that includes http://www.spinics.net/lists/linux-mm/msg65653.html
for more information.
7. Applied smp_mb__after_unlock_lock() as needed in RCU.
8. Make smp_mb__after_unlock_lock() be a full memory barrier for powerpc.
Changes from v5:
o Added #8 (full memory barrier for powerpc).
o Made the definition of smp_mb__after_unlock_lock() precede its
documentation as suggested by Josh Triplett.
o Added verbiage describing acquire and release semantics of
LOCK and UNLOCK, respectively.
o Updates based on Oleg Nesterov review.
Changes from v4:
o Added Josh Triplett's Reviewed-by for 1-4.
o Applied feedback from Ingo Molnar and Jonathan Corbet.
o Trimmed Cc lists as suggested by David Miller.
o Added smp_mb__after_unlock_lock() changes.
Changes from v3:
o Fix typos noted by Peter Zijlstra.
o Added the documentation about ACCESS_ONCE(), which expands on
http://thread.gmane.org/gmane.linux.kernel.mm/82891/focus=14696,
ably summarized by Jon Corbet at http://lwn.net/Articles/508991/.
Changes from v2:
o Update examples so that that load against which the subsequent
store is to be ordered is part of the "if" condition.
o Add an example showing how the compiler can remove "if"
conditions and how to prevent it from doing so.
o Add ACCESS_ONCE() to the compiler-barrier section.
o Add a sentence noting that transitivity requires smp_mb().
Changes from v1:
o Combined with Peter Zijlstra's speculative-store-prohibition patch.
o Added more pitfalls to avoid when prohibiting speculative
stores, along with how to avoid them.
o Applied Josh Triplett's review comments.
Thanx, Paul
------------------------------------------------------------------------
next reply other threads:[~2013-12-11 21:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 21:58 Paul E. McKenney [this message]
2013-12-11 21:59 ` [PATCH v6 tip/core/locking 1/8] Documentation/memory-barriers.txt: Add needed ACCESS_ONCE() calls to memory-barriers.txt Paul E. McKenney
2013-12-11 21:59 ` [PATCH v6 tip/core/locking 2/8] Documentation/memory-barriers.txt: Add long atomic examples " Paul E. McKenney
2013-12-16 10:39 ` [tip:core/locking] " tip-bot for Paul E. McKenney
2013-12-11 21:59 ` [PATCH v6 tip/core/locking 3/8] Documentation/memory-barriers.txt: Prohibit speculative writes Paul E. McKenney
2013-12-12 13:17 ` Ingo Molnar
2013-12-12 15:08 ` Paul E. McKenney
2013-12-13 14:18 ` Peter Zijlstra
2013-12-16 10:39 ` [tip:core/locking] " tip-bot for Peter Zijlstra
2013-12-11 21:59 ` [PATCH v6 tip/core/locking 4/8] Documentation/memory-barriers.txt: Document ACCESS_ONCE() Paul E. McKenney
2013-12-16 10:40 ` [tip:core/locking] " tip-bot for Paul E. McKenney
2013-12-11 21:59 ` [PATCH v6 tip/core/locking 5/8] locking: Add an smp_mb__after_unlock_lock() for UNLOCK+LOCK barrier Paul E. McKenney
2013-12-16 10:40 ` [tip:core/locking] locking: Add an smp_mb__after_unlock_lock() for UNLOCK+BLOCK barrier tip-bot for Paul E. McKenney
2013-12-11 21:59 ` [PATCH v6 tip/core/locking 6/8] Documentation/memory-barriers.txt: Downgrade UNLOCK+LOCK Paul E. McKenney
2013-12-16 10:40 ` [tip:core/locking] Documentation/memory-barriers.txt: Downgrade UNLOCK+BLOCK tip-bot for Paul E. McKenney
2013-12-11 21:59 ` [PATCH v6 tip/core/locking 7/8] rcu: Apply smp_mb__after_unlock_lock() to preserve grace periods Paul E. McKenney
2013-12-16 10:40 ` [tip:core/locking] " tip-bot for Paul E. McKenney
2013-12-11 21:59 ` [PATCH v6 tip/core/locking 8/8] powerpc: Full barrier for smp_mb__after_unlock_lock() Paul E. McKenney
2013-12-16 10:40 ` [tip:core/locking] " tip-bot for Paul E. McKenney
2013-12-16 10:39 ` [tip:core/locking] Documentation/memory-barriers.txt: Add needed ACCESS_ONCE() calls to memory-barriers.txt tip-bot for Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211215850.GA810@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=darren@dvhart.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=niv@us.ibm.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sbw@mit.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox