From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Jiri Kosina <trivial@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 2/2] regulator: s5m8767: Fix driver probe fail on BUCK7/8 regulators
Date: Wed, 11 Dec 2013 22:51:16 +0000 [thread overview]
Message-ID: <20131211225116.GC11044@sirena.org.uk> (raw)
In-Reply-To: <1386666583-3280-2-git-send-email-k.kozlowski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
On Tue, Dec 10, 2013 at 10:09:43AM +0100, Krzysztof Kozlowski wrote:
> The BUCK7 and BUCK8 were not supported by s5m8767 driver. If they were
> configured in DTS then the driver probing would fail with EINVAL:
> [ 0.288474] VCC_SUB_1.35V: failed to apply 1350000uV constraint
> [ 0.288671] s5m8767-pmic s5m8767-pmic: regulator init failed for 35
> [ 0.294931] s5m8767-pmic: probe of s5m8767-pmic failed with error -22
> This patch adds support for BUCK7 and BUCK8 regulators using standard
> regmap get/set voltage sel functions.
I've applied these but this changelog doesn't entirely add up so I
rewrote it a bit. The patch is implementing the get and set voltage
operations, the regulators were actually supported. The errors were
being caused by the DT attempting to set the voltage for a fixed voltage
regulator which obviously won't work - I suspect that the DTs might not
be ideal, it seems common to overspecify voltages in DTs for some
reason.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-11 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 9:09 [TRIVIAL PATCH 1/2] regulator: s5m8767: Define symbol for buck control mask Krzysztof Kozlowski
2013-12-10 9:09 ` [PATCH 2/2] regulator: s5m8767: Fix driver probe fail on BUCK7/8 regulators Krzysztof Kozlowski
2013-12-11 22:51 ` Mark Brown [this message]
2013-12-10 9:18 ` [TRIVIAL PATCH 1/2] regulator: s5m8767: Define symbol for buck control mask Sachin Kamat
2013-12-10 9:30 ` Krzysztof Kozlowski
2013-12-10 9:38 ` Sachin Kamat
2013-12-10 9:56 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211225116.GC11044@sirena.org.uk \
--to=broonie@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox