From: Ingo Molnar <mingo@kernel.org>
To: Kyungmin Park <kyungmin.park@samsung.com>
Cc: "'Peter Zijlstra'" <peterz@infradead.org>,
"'Andrzej Pietrasiewicz'" <andrzej.p@samsung.com>,
linux-kernel@vger.kernel.org,
"'Marek Szyprowski'" <m.szyprowski@samsung.com>,
"'Ingo Molnar'" <mingo@redhat.com>
Subject: Re: [PATCH v2] kernel/locking: mutex: simplify access to the first entry in the wait-list
Date: Thu, 12 Dec 2013 13:47:43 +0100 [thread overview]
Message-ID: <20131212124743.GB5806@gmail.com> (raw)
In-Reply-To: <23bd01cef731$fb052680$f10f7380$%park@samsung.com>
* Kyungmin Park <kyungmin.park@samsung.com> wrote:
>
> > -----Original Message-----
> > From: Peter Zijlstra [mailto:peterz@infradead.org]
> > Sent: Thursday, December 12, 2013 8:35 PM
> > To: Andrzej Pietrasiewicz
> > Cc: linux-kernel@vger.kernel.org; Kyungmin Park; Marek Szyprowski; Ingo
> > Molnar
> > Subject: Re: [PATCH v2] kernel/locking: mutex: simplify access to the
> > first entry in the wait-list
> >
> > On Thu, Dec 12, 2013 at 12:29:32PM +0100, Andrzej Pietrasiewicz wrote:
> > > Use list_first_entry instead of explicitly accessing the first entry
> > > with "head".next. The comment one line above becomes obsolete.
> > >
> > > Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > > ---
> > >
> > > v1..v2:
> > >
> > > - corrected the email address in the second Signed-off-by line
> >
> > Still invalid; the problem is that you appear to have written the patch
> > (you send it and you have first sob).
>
>
> > So what is Kyungmin doing in the line? He did not send me your patch.
>
> Internal review process, and it represents this patch comes from.
That can be expressed via a Reviewed-by line.
Thanks,
Ingo
next prev parent reply other threads:[~2013-12-12 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 11:29 [PATCH v2] kernel/locking: mutex: simplify access to the first entry in the wait-list Andrzej Pietrasiewicz
2013-12-12 11:35 ` Peter Zijlstra
2013-12-12 12:02 ` Kyungmin Park
2013-12-12 12:47 ` Ingo Molnar [this message]
2013-12-12 12:52 ` Peter Zijlstra
2013-12-13 6:24 ` Andrzej Pietrasiewicz
2013-12-13 14:00 ` Peter Zijlstra
2013-12-13 14:08 ` Ingo Molnar
2013-12-14 17:26 ` Greg Kroah-Hartman
2013-12-13 14:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212124743.GB5806@gmail.com \
--to=mingo@kernel.org \
--cc=andrzej.p@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox