From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751943Ab3LLOVR (ORCPT ); Thu, 12 Dec 2013 09:21:17 -0500 Received: from merlin.infradead.org ([205.233.59.134]:36005 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489Ab3LLOVM (ORCPT ); Thu, 12 Dec 2013 09:21:12 -0500 Message-Id: <20131212141654.999650465@infradead.org> User-Agent: quilt/0.60-1 Date: Thu, 12 Dec 2013 15:08:42 +0100 From: Peter Zijlstra To: Arjan van de Ven , lenb@kernel.org, rjw@rjwysocki.net, Eliezer Tamir , rui.zhang@intel.com, jacob.jun.pan@linux.intel.com, Mike Galbraith , Ingo Molnar , hpa@zytor.com, paulmck@linux.vnet.ibm.com, Thomas Gleixner , John Stultz , Andy Lutomirski , Peter Zijlstra Cc: linux-kernel@vger.kernel.org Subject: [PATCH 07/15] sched, thermal: Clean up preempt_enable_no_resched() abuse References: <20131212140835.729222186@infradead.org> Content-Disposition: inline; filename=peterz-fixup-intel-powerclamp.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The only valid use of preempt_enable_no_resched() is if the very next line is schedule() or if we know preemption cannot actually be enabled by that statement due to known more preempt_count 'refs'. Cc: rjw@rjwysocki.net Cc: Eliezer Tamir Cc: rui.zhang@intel.com Cc: jacob.jun.pan@linux.intel.com Cc: Mike Galbraith Cc: Ingo Molnar Cc: hpa@zytor.com Cc: Arjan van de Ven Cc: lenb@kernel.org Signed-off-by: Peter Zijlstra --- drivers/thermal/intel_powerclamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/thermal/intel_powerclamp.c +++ b/drivers/thermal/intel_powerclamp.c @@ -443,7 +443,7 @@ static int clamp_thread(void *arg) atomic_inc(&idle_wakeup_counter); } tick_nohz_idle_exit(); - preempt_enable_no_resched(); + preempt_enable(); } del_timer_sync(&wakeup_timer); clear_bit(cpunr, cpu_clamping_mask);