Re: [PATCH v2 2/4] pciehp: Use link change notifications for hot-plug and removal

Guenter Roeck
2013-12-14T03:39:16Z

On Fri, Dec 13, 2013 at 05:58:08PM -0800, Yinghai Lu wrote:
> On Fri, Dec 13, 2013 at 1:14 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> > On Fri, Dec 13, 2013 at 12:04 PM, Rajat Jain <rajatjain@juniper.net> wrote:
> >
> >> Once again: the way I interpret this is:
> >> * Always enable Link events.
> >> * Disable presence events if attention button is present.
> >
> > That sounds like a good plan to me.
>
> How about Diag_Reset from MPT2SAS and others?
> link could up and down
>

Good question. Another question is how this would play together
with AER functions, specifically link_reset and slot_reset.

In this context ... is it possible that the link_reset function from struct
pci_error_handlers is never called, or am I missing something ?

Guenter