From: David Cohen <david.a.cohen@linux.intel.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] usb: host: xhci: Move suspend ops under PM_SLEEP to avoid warning
Date: Thu, 12 Dec 2013 21:23:34 -0800 [thread overview]
Message-ID: <20131213052334.GA2403@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <20131213032555.GA31992@psi-dev26.jf.intel.com>
On Thu, Dec 12, 2013 at 07:25:55PM -0800, David Cohen wrote:
> On Thu, Dec 12, 2013 at 09:01:04PM -0500, Santosh Shilimkar wrote:
> > On Thursday 12 December 2013 08:51 PM, David Cohen wrote:
> > > On Thu, Dec 12, 2013 at 08:06:24PM -0500, Santosh Shilimkar wrote:
> > >> Otherwise you get below build warnings
> > >>
> > >> drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function]
> > >> drivers/usb/host/xhci-plat.c:209:12: warning: ‘xhci_plat_resume’ defined but not used [-Wunused-function]
> > >>
> > >> Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>
> > >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > >> ---
> > >> drivers/usb/host/xhci-plat.c | 4 ++--
> > >> 1 file changed, 2 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > >> index d9c169f..4875be5 100644
> > >> --- a/drivers/usb/host/xhci-plat.c
> > >> +++ b/drivers/usb/host/xhci-plat.c
> > >> @@ -197,7 +197,7 @@ static int xhci_plat_remove(struct platform_device *dev)
> > >> return 0;
> > >> }
> > >>
> > >> -#ifdef CONFIG_PM
> > >> +#ifdef CONFIG_PM_SLEEP
> > >
> > > Can't you just remove these #ifdefs altogether?
> > > xhci_plat_pm_ops is set using SET_SYSTEM_SLEEP_PM_OPS() macro which
> > > already handles '#ifdef CONFIG_PM_SLEEP' case.
> > >
> > It does handle the difference but the hooks implemented would
> > show-up un-used warning if you remove the #ifdefs.
> >
> > drivers/usb/host/xhci-plat.c:200:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function]
> > drivers/usb/host/xhci-plat.c:208:12: warning: ‘xhci_plat_resume’ defined but not used [-Wunused-function]
> >
> > So you need to wrap them under the PM_SLEEP check.
>
> Yeah... it's not smart enought :)
> But you could still remove the #else condition and the ugly DEV_PM_OPS
> macro.
Since this patch is not urgent, I sent a RFC proposing smarter
SET_*_PM_OPS(). I included your patch (a bit different) here:
https://patchwork.kernel.org/patch/3337961/
Br, David
>
> Br, David
>
> >
> > Regards,
> > Santosh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-12-13 5:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 1:06 [PATCH] usb: host: xhci: Move suspend ops under PM_SLEEP to avoid warning Santosh Shilimkar
2013-12-13 1:51 ` David Cohen
2013-12-13 2:01 ` Santosh Shilimkar
2013-12-13 3:25 ` David Cohen
2013-12-13 5:23 ` David Cohen [this message]
2013-12-13 22:55 ` Santosh Shilimkar
2013-12-14 1:16 ` David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213052334.GA2403@psi-dev26.jf.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox