From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752008Ab3LMFSp (ORCPT ); Fri, 13 Dec 2013 00:18:45 -0500 Received: from mga11.intel.com ([192.55.52.93]:56747 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751825Ab3LMFSn (ORCPT ); Fri, 13 Dec 2013 00:18:43 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,476,1384329600"; d="scan'208";a="443527756" Date: Thu, 12 Dec 2013 21:23:34 -0800 From: David Cohen To: Santosh Shilimkar Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Sarah Sharp , Greg Kroah-Hartman Subject: Re: [PATCH] usb: host: xhci: Move suspend ops under PM_SLEEP to avoid warning Message-ID: <20131213052334.GA2403@psi-dev26.jf.intel.com> References: <1386896784-23916-1-git-send-email-santosh.shilimkar@ti.com> <20131213015133.GA29964@psi-dev26.jf.intel.com> <52AA6A60.7050308@ti.com> <20131213032555.GA31992@psi-dev26.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20131213032555.GA31992@psi-dev26.jf.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2013 at 07:25:55PM -0800, David Cohen wrote: > On Thu, Dec 12, 2013 at 09:01:04PM -0500, Santosh Shilimkar wrote: > > On Thursday 12 December 2013 08:51 PM, David Cohen wrote: > > > On Thu, Dec 12, 2013 at 08:06:24PM -0500, Santosh Shilimkar wrote: > > >> Otherwise you get below build warnings > > >> > > >> drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function] > > >> drivers/usb/host/xhci-plat.c:209:12: warning: ‘xhci_plat_resume’ defined but not used [-Wunused-function] > > >> > > >> Cc: Sarah Sharp > > >> Cc: Greg Kroah-Hartman > > >> Signed-off-by: Santosh Shilimkar > > >> --- > > >> drivers/usb/host/xhci-plat.c | 4 ++-- > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > > >> index d9c169f..4875be5 100644 > > >> --- a/drivers/usb/host/xhci-plat.c > > >> +++ b/drivers/usb/host/xhci-plat.c > > >> @@ -197,7 +197,7 @@ static int xhci_plat_remove(struct platform_device *dev) > > >> return 0; > > >> } > > >> > > >> -#ifdef CONFIG_PM > > >> +#ifdef CONFIG_PM_SLEEP > > > > > > Can't you just remove these #ifdefs altogether? > > > xhci_plat_pm_ops is set using SET_SYSTEM_SLEEP_PM_OPS() macro which > > > already handles '#ifdef CONFIG_PM_SLEEP' case. > > > > > It does handle the difference but the hooks implemented would > > show-up un-used warning if you remove the #ifdefs. > > > > drivers/usb/host/xhci-plat.c:200:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function] > > drivers/usb/host/xhci-plat.c:208:12: warning: ‘xhci_plat_resume’ defined but not used [-Wunused-function] > > > > So you need to wrap them under the PM_SLEEP check. > > Yeah... it's not smart enought :) > But you could still remove the #else condition and the ugly DEV_PM_OPS > macro. Since this patch is not urgent, I sent a RFC proposing smarter SET_*_PM_OPS(). I included your patch (a bit different) here: https://patchwork.kernel.org/patch/3337961/ Br, David > > Br, David > > > > > Regards, > > Santosh > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html