From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Robin Holt <robinmholt@gmail.com>,
Cliff Whickman <cpw@sgi.com>
Subject: Re: [PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c
Date: Fri, 13 Dec 2013 00:56:51 -0800 [thread overview]
Message-ID: <20131213085651.GB4386@leaf> (raw)
In-Reply-To: <49ece621a2dbbdfad71e81c3185d7e8a32c52823.1386915618.git.rashika.kheria@gmail.com>
On Fri, Dec 13, 2013 at 12:21:20PM +0530, Rashika Kheria wrote:
> This patch marks the function xp_init() and xp_exit() as static in
> sgi-xp/xp_main.c because they are not used outside this file.
>
> Thus, it also eliminates the following warnings in sgi-xp/xp_main.c:
> drivers/misc/sgi-xp/xp_main.c:249:1: warning: no previous prototype for ‘xp_init’ [-Wmissing-prototypes]
> drivers/misc/sgi-xp/xp_main.c:274:1: warning: no previous prototype for ‘xp_exit’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/misc/sgi-xp/xp_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/sgi-xp/xp_main.c b/drivers/misc/sgi-xp/xp_main.c
> index 01be66d..df14c70 100644
> --- a/drivers/misc/sgi-xp/xp_main.c
> +++ b/drivers/misc/sgi-xp/xp_main.c
> @@ -245,7 +245,7 @@ xpc_disconnect(int ch_number)
> }
> EXPORT_SYMBOL_GPL(xpc_disconnect);
>
> -int __init
> +static int __init
> xp_init(void)
> {
> enum xp_retval ret;
> @@ -270,7 +270,7 @@ xp_init(void)
>
> module_init(xp_init);
>
> -void __exit
> +static void __exit
> xp_exit(void)
> {
> if (is_shub())
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-12-13 8:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 6:42 [PATCH 1/5] drivers: misc: Mark functions as static in grukservices.c Rashika Kheria
2013-12-13 6:51 ` [PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c Rashika Kheria
2013-12-13 8:56 ` Josh Triplett [this message]
2013-12-13 17:14 ` Robin Holt
2013-12-13 6:54 ` [PATCH 3/5] drivers: misc: Mark functions as static in xpc_main.c Rashika Kheria
2013-12-13 8:57 ` Josh Triplett
2013-12-13 17:14 ` Robin Holt
2013-12-13 6:57 ` [PATCH 4/5] drivers: misc: Mark functions as static in ad525x_dpot.c Rashika Kheria
2013-12-13 8:19 ` Michael Hennerich
2013-12-13 8:57 ` Josh Triplett
2013-12-13 6:59 ` [PATCH 5/5] drivers: misc: Mark function jp_generic_ide_ioctl() as static in lkdtm.c Rashika Kheria
2013-12-13 8:58 ` Josh Triplett
2013-12-13 8:56 ` [PATCH 1/5] drivers: misc: Mark functions as static in grukservices.c Josh Triplett
2013-12-13 14:44 ` Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213085651.GB4386@leaf \
--to=josh@joshtriplett.org \
--cc=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=robinmholt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox