From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752448Ab3LMI6T (ORCPT ); Fri, 13 Dec 2013 03:58:19 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41317 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752171Ab3LMI6S convert rfc822-to-8bit (ORCPT ); Fri, 13 Dec 2013 03:58:18 -0500 X-Originating-IP: 50.43.14.201 Date: Fri, 13 Dec 2013 00:58:11 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman Subject: Re: [PATCH 5/5] drivers: misc: Mark function jp_generic_ide_ioctl() as static in lkdtm.c Message-ID: <20131213085811.GE4386@leaf> References: <40521f78bafae3cc4e796c540d3c497d79eeb63e.1386915618.git.rashika.kheria@gmail.com> <9100647978d5025b699bfec244f35bbc8ef0f7d7.1386915618.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9100647978d5025b699bfec244f35bbc8ef0f7d7.1386915618.git.rashika.kheria@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 13, 2013 at 12:29:42PM +0530, Rashika Kheria wrote: > This patch marks the function jp_generic_ide_ioctl() as static in > lkdtm.c because it is not used outside this file. > > Thus, it also eliminates the following warnings in lkdtm.c: > drivers/misc/lkdtm.c:227:5: warning: no previous prototype for ‘jp_generic_ide_ioctl’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/misc/lkdtm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c > index a2edb2e..79b677e 100644 > --- a/drivers/misc/lkdtm.c > +++ b/drivers/misc/lkdtm.c > @@ -224,7 +224,7 @@ static int jp_scsi_dispatch_cmd(struct scsi_cmnd *cmd) > } > > #ifdef CONFIG_IDE > -int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file, > +static int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file, > struct block_device *bdev, unsigned int cmd, > unsigned long arg) > { > -- > 1.7.9.5 >