From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752477Ab3LMI6r (ORCPT ); Fri, 13 Dec 2013 03:58:47 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:38608 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751773Ab3LMI6q convert rfc822-to-8bit (ORCPT ); Fri, 13 Dec 2013 03:58:46 -0500 X-Originating-IP: 50.43.14.201 Date: Fri, 13 Dec 2013 00:58:40 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Eric Piel , Matthew Garrett , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 1/2] drivers: platform: Mark functions as static in hp_accel.c Message-ID: <20131213085839.GF4386@leaf> References: <89355c5023baba63de7d1313b3f52818b0fb9202.1386919194.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <89355c5023baba63de7d1313b3f52818b0fb9202.1386919194.git.rashika.kheria@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 13, 2013 at 12:56:34PM +0530, Rashika Kheria wrote: > This patch marks the functions lis3lv02d_acpi_init(), > lis3lv02d_acpi_read() and lis3lv02d_acpi_write() as static in > x86/hp_accel.c because they are not used outside this file. > > Thus, it also eliminates the following warnings in x86/hp_accel.c: > drivers/platform/x86/hp_accel.c:91:5: warning: no previous prototype for ‘lis3lv02d_acpi_init’ [-Wmissing-prototypes] > drivers/platform/x86/hp_accel.c:109:5: warning: no previous prototype for ‘lis3lv02d_acpi_read’ [-Wmissing-prototypes] > drivers/platform/x86/hp_accel.c:132:5: warning: no previous prototype for ‘lis3lv02d_acpi_write’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/platform/x86/hp_accel.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c > index a8e43cf..01b619e 100644 > --- a/drivers/platform/x86/hp_accel.c > +++ b/drivers/platform/x86/hp_accel.c > @@ -88,7 +88,7 @@ MODULE_DEVICE_TABLE(acpi, lis3lv02d_device_ids); > * > * Returns 0 on success. > */ > -int lis3lv02d_acpi_init(struct lis3lv02d *lis3) > +static int lis3lv02d_acpi_init(struct lis3lv02d *lis3) > { > struct acpi_device *dev = lis3->bus_priv; > if (acpi_evaluate_object(dev->handle, METHOD_NAME__INI, > @@ -106,7 +106,7 @@ int lis3lv02d_acpi_init(struct lis3lv02d *lis3) > * > * Returns 0 on success. > */ > -int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret) > +static int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret) > { > struct acpi_device *dev = lis3->bus_priv; > union acpi_object arg0 = { ACPI_TYPE_INTEGER }; > @@ -129,7 +129,7 @@ int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret) > * > * Returns 0 on success. > */ > -int lis3lv02d_acpi_write(struct lis3lv02d *lis3, int reg, u8 val) > +static int lis3lv02d_acpi_write(struct lis3lv02d *lis3, int reg, u8 val) > { > struct acpi_device *dev = lis3->bus_priv; > unsigned long long ret; /* Not used when writting */ > -- > 1.7.9.5 >