From: "Heiko Stübner" <heiko@sntech.de>
To: kgene@kernel.org
Cc: "'José Miguel Gonçalves'" <jose.goncalves@inov.pt>,
"'Linus Walleij'" <linus.walleij@linaro.org>,
"'Tomasz Figa'" <t.figa@samsung.com>,
'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.
Date: Fri, 13 Dec 2013 10:29:19 +0100 [thread overview]
Message-ID: <201312131029.20078.heiko@sntech.de> (raw)
In-Reply-To: <0bc301cef7e5$319ac0c0$94d04240$@kernel.org>
Am Freitag, 13. Dezember 2013, 10:24:59 schrieb kgene@kernel.org:
> José Miguel Gonçalves wrote:
> > On 27-09-2013 15:17, Linus Walleij wrote:
> > > On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
> > >
> > > <jose.goncalves@inov.pt> wrote:
> > >> Some GPIO line limits are incorrectly set which, for instance,
> > >> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
> > >>
> > >> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
> > >> ---
> > >>
> > >> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
> > >
> > > OK but grrrr!
> > >
> > > What needs to happen to the s3c24xx is to get rid of this file.
> > >
> > > - Define ARCH_NR_GPIOS in arch/arm/Kconfig entry
> > >
> > > ARCH_NR_GPIO like everyone else
> > >
> > > - Get rid of the config symbol NEED_MACH_GPIO_H
> > >
> > > - Move this file down into arch/arm/mach-s3c24xx/s3c24xx-gpio.h
> > >
> > > or whatever and make it local...
> > >
> > > I will try to do this myself if noone else helps out, so I'd like to
> > > carry this patch in the GPIO tree provided I can get an ACK from
> > > the S3C24xx maintainer. Tomasz, is that you or Kukjin?
> > >
> > > (BTW the above maybe goes for S3c64xx as well .. and S5P
> > > oh well I will get to it.)
> >
> > Was this patch forgotten?
>
> Hi Jose,
>
> Sorry about missing your patch. It's my fault :( and as you know, at this
> moment the file will be removed by Linus' patch...
>
> Anyway, let me look at the Samsung patches closely ;)
The comment that is changed in the header is removed by Linus' patch, but the
change to the gpio driver is still relevant for the time being I'd think.
Heiko
next prev parent reply other threads:[~2013-12-13 9:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 8:46 [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX José Miguel Gonçalves
2013-09-11 16:27 ` Heiko Stübner
2013-09-27 14:17 ` Linus Walleij
2013-12-13 1:55 ` José Miguel Gonçalves
2013-12-13 8:12 ` Linus Walleij
2013-12-13 8:42 ` Heiko Stübner
2013-12-13 9:38 ` José Miguel Gonçalves
2013-12-13 9:24 ` kgene
2013-12-13 9:29 ` Heiko Stübner [this message]
2013-12-13 9:37 ` Linus Walleij
2013-12-20 9:12 ` Linus Walleij
2013-12-20 20:57 ` Kukjin Kim
2014-01-02 12:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312131029.20078.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=jose.goncalves@inov.pt \
--cc=kgene@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox