From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
mukesh.rathor@oracle.com, tim@xen.org, jbeulich@suse.com,
boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH V10 05/14] xen/pvh: balloon and grant changes.
Date: Fri, 13 Dec 2013 10:47:22 -0500 [thread overview]
Message-ID: <20131213154722.GA7214@phenom.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1312131530030.8667@kaball.uk.xensource.com>
> > > > > These changes to balloon.c are similar to my patch but:
> > > > >
> > > > > - they don't prevent set_phys_to_machine from being called by
> > > > > increase_reservation for auto_translated guests
> > > >
> > > > <nods>
> > > > >
> > > > > - they don't prevent wasteful balloon_scratch_page from being allocated
> > > > > for auto_translated guests
> > > >
> > > > <nods>
> > > > >
> > > > > I think that it would be best to take my patch instead.
> > > >
> > > > Lets focus the review on your patch then and have it part of this
> > > > series.
> > >
> > > OK, but keep in mind that Xen on ARMv8 is currently broken without that
> > > patch.
> >
> > Hm. We could have another patch to just disable BALLOON on ARMv8 :-)
> >
> > The question you have to ask - if your patch causes regression are you
> > OK tracking/fixing it over the holidays :-) If yes, then yes - we can
> > put that in v3.13-rc3 to make it work properly on ARMv8.
>
> Damn, that was a good argument.
> After thinking more about it, I think that I, or a member of my team,
> can actually fix possible bugs during the holidays. Especially
> considering that the patch doesn't alter the behavior of PV guests.
>
> So in short, yes :)
Great <evil laughther>! Could you repost it with the description changes?
Or if you OK with the changes I had proposed - just tell me "yes" and I will
alter it.
next prev parent reply other threads:[~2013-12-13 15:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 2:10 [PATCH v10] Repost of PVH patches for Linux Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 01/14] xen/pvh: Support ParaVirtualized Hardware extensions Konrad Rzeszutek Wilk
2013-12-13 10:44 ` David Vrabel
2013-12-13 14:32 ` Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 02/14] xen/pvh: Extend vcpu_guest_context, p2m, event, and XenBus Konrad Rzeszutek Wilk
2013-12-13 10:56 ` David Vrabel
2013-12-13 14:26 ` Konrad Rzeszutek Wilk
2013-12-13 14:59 ` Stefano Stabellini
2013-12-13 2:10 ` [PATCH V10 03/14] xen/pvh: Implement MMU changes for PVH Konrad Rzeszutek Wilk
2013-12-13 16:54 ` Boris Ostrovsky
2013-12-13 2:10 ` [PATCH V10 04/14] xen/pvh: bootup and setup (E820) related changes Konrad Rzeszutek Wilk
2013-12-13 17:55 ` Boris Ostrovsky
2013-12-17 21:39 ` Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 05/14] xen/pvh: balloon and grant changes Konrad Rzeszutek Wilk
2013-12-13 11:02 ` David Vrabel
2013-12-13 11:56 ` Stefano Stabellini
2013-12-13 14:36 ` Konrad Rzeszutek Wilk
2013-12-13 14:49 ` Stefano Stabellini
2013-12-13 14:59 ` Konrad Rzeszutek Wilk
2013-12-13 15:34 ` Stefano Stabellini
2013-12-13 15:47 ` Konrad Rzeszutek Wilk [this message]
2013-12-13 15:51 ` Stefano Stabellini
2013-12-13 2:10 ` [PATCH V10 06/14] xen: x86 pvh: use XENMEM_add_to_physmap_range for foreign gmfn mappings Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 07/14] xen/x86: remove duplicated include from enlighten.c Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 08/14] x86/xen: Use __pa_symbol instead of __pa on C visible symbols Konrad Rzeszutek Wilk
2013-12-13 11:04 ` David Vrabel
2013-12-13 14:24 ` Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 09/14] xen: implement updated XENMEM_add_to_physmap_range ABI Konrad Rzeszutek Wilk
2013-12-13 11:35 ` David Vrabel
2013-12-13 14:27 ` Konrad Rzeszutek Wilk
2013-12-13 14:30 ` David Vrabel
2013-12-13 2:10 ` [PATCH V10 10/14] xen/pvh: specify xen features strings cleanly for PVH Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 11/14] xen/pvh: remove code to map iomem from guest Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 12/14] xen/pvh: Use ballooning to allocate grant table pages [v2] Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 13/14] x86/xen: remove depends on CONFIG_EXPERIMENTAL Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 14/14] xen/pvh: vcpu info placement, load CS selector, and remove debug printk Konrad Rzeszutek Wilk
2013-12-13 11:34 ` David Vrabel
2013-12-13 11:37 ` [PATCH v10] Repost of PVH patches for Linux David Vrabel
2013-12-13 14:30 ` [Xen-devel] " Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213154722.GA7214@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox