From: Rashika Kheria <rashika.kheria@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Pavel Machek <pavel@ucw.cz>, Stephen Warren <swarren@nvidia.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Rashika Kheria <rashika.kheria@gmail.com>,
josh@joshtriplett.org
Subject: [PATCH] drivers: reset: Mark function as static in core.c
Date: Sat, 14 Dec 2013 18:56:10 +0530 [thread overview]
Message-ID: <20131214132610.GA8691@rashika> (raw)
This patch marks the function of_reset_simple_xlate() and
devm_reset_control_put() as static in core.c because it is not used
outside this file.
Thus, it also eliminate the following warnings in core.c:
drivers/reset/core.c:46:5: warning: no previous prototype for ‘of_reset_simple_xlate’ [-Wmissing-prototypes]
drivers/reset/core.c:262:6: warning: no previous prototype for ‘devm_reset_control_put’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/reset/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index d1b6089..8604053 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -43,7 +43,7 @@ struct reset_control {
* This simple translation function should be used for reset controllers
* with 1:1 mapping, where reset lines can be indexed by number without gaps.
*/
-int of_reset_simple_xlate(struct reset_controller_dev *rcdev,
+static int of_reset_simple_xlate(struct reset_controller_dev *rcdev,
const struct of_phandle_args *reset_spec)
{
if (WARN_ON(reset_spec->args_count != rcdev->of_reset_n_cells))
@@ -259,7 +259,7 @@ static int devm_reset_control_match(struct device *dev, void *res, void *data)
* This function will not need to be called normally, as devres will take
* care of freeing the resource.
*/
-void devm_reset_control_put(struct reset_control *rstc)
+static void devm_reset_control_put(struct reset_control *rstc)
{
int ret;
--
1.7.9.5
next reply other threads:[~2013-12-14 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 13:26 Rashika Kheria [this message]
2013-12-14 14:15 ` [PATCH] drivers: reset: Mark function as static in core.c Dan Carpenter
2013-12-14 20:56 ` Josh Triplett
2013-12-14 21:37 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214132610.GA8691@rashika \
--to=rashika.kheria@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pavel@ucw.cz \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox