From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Doug Thompson <dougthompson@xmission.com>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers: edac: Mark the function get_mci_for_node_id() as static in sb_edac.c
Date: Sat, 14 Dec 2013 12:28:58 -0800 [thread overview]
Message-ID: <20131214202857.GE17601@leaf> (raw)
In-Reply-To: <0441f508186fc4eeabc8e9c3e4dde013d99405d4.1387029387.git.rashika.kheria@gmail.com>
On Sat, Dec 14, 2013 at 07:32:09PM +0530, Rashika Kheria wrote:
> This patch marks the function get_mci_for_node_id() as static in
> sb_edac.c because it is not used outside this file.
>
> Thus, it also eliminates the following warning in sb_edac.c:
> drivers/edac/sb_edac.c:918:22: warning: no previous prototype for ‘get_mci_for_node_id’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/edac/sb_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 8472405..a8845a3 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -915,7 +915,7 @@ static void get_memory_layout(const struct mem_ctl_info *mci)
> }
> }
>
> -struct mem_ctl_info *get_mci_for_node_id(u8 node_id)
> +static struct mem_ctl_info *get_mci_for_node_id(u8 node_id)
> {
> struct sbridge_dev *sbridge_dev;
>
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-12-14 20:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 13:58 [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c Rashika Kheria
2013-12-14 14:00 ` [PATCH 2/3] drivers: edac: Mark the function edac_create_debug_nodes() as static in edac_mc_sysfs.c Rashika Kheria
2013-12-14 20:28 ` Josh Triplett
2013-12-15 17:00 ` Borislav Petkov
2013-12-14 14:02 ` [PATCH 3/3] drivers: edac: Mark the function get_mci_for_node_id() as static in sb_edac.c Rashika Kheria
2013-12-14 20:28 ` Josh Triplett [this message]
2013-12-15 17:03 ` Borislav Petkov
2013-12-14 17:01 ` [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c Borislav Petkov
2013-12-14 18:17 ` Rashika Kheria
2013-12-14 20:42 ` Borislav Petkov
2013-12-14 20:28 ` Josh Triplett
2013-12-15 16:58 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214202857.GE17601@leaf \
--to=josh@joshtriplett.org \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox