* [PATCH 2/3] drivers: rapidio: Include appropriate header file in rio-driver.c
2013-12-14 12:46 [PATCH 1/3] drivers: rapidio: Include appropriate header file in rio-access.c Rashika Kheria
@ 2013-12-14 12:50 ` Rashika Kheria
2013-12-14 20:34 ` Josh Triplett
2013-12-18 18:22 ` Bounine, Alexandre
2013-12-14 12:53 ` [PATCH 3/3] drivers: rapidio: Remove unused function rio_remove_sysfs_dev_files() in rio-sysfs.c Rashika Kheria
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Rashika Kheria @ 2013-12-14 12:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Matt Porter, Alexandre Bounine, josh
This patch includes the header file linux/rio_drv.h in rio-driver.c
because functions rio_dev_get(), rio_dev_put(), rio_register_driver()
and rio_unregister_driver() have their prototype declarations in
linux/rio_drv.h.
Thus, it also eliminates the following warnings in rio-driver.c:
drivers/rapidio/rio-driver.c:57:17: warning: no previous prototype for ‘rio_dev_get’ [-Wmissing-prototypes]
drivers/rapidio/rio-driver.c:74:6: warning: no previous prototype for ‘rio_dev_put’ [-Wmissing-prototypes]
drivers/rapidio/rio-driver.c:143:5: warning: no previous prototype for ‘rio_register_driver’ [-Wmissing-prototypes]
drivers/rapidio/rio-driver.c:162:6: warning: no previous prototype for ‘rio_unregister_driver’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/rapidio/rio-driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rapidio/rio-driver.c b/drivers/rapidio/rio-driver.c
index c9ae692..df73419 100644
--- a/drivers/rapidio/rio-driver.c
+++ b/drivers/rapidio/rio-driver.c
@@ -13,6 +13,7 @@
#include <linux/init.h>
#include <linux/module.h>
#include <linux/rio.h>
+#include <linux/rio_drv.h>
#include <linux/rio_ids.h>
#include "rio.h"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] drivers: rapidio: Include appropriate header file in rio-driver.c
2013-12-14 12:50 ` [PATCH 2/3] drivers: rapidio: Include appropriate header file in rio-driver.c Rashika Kheria
@ 2013-12-14 20:34 ` Josh Triplett
2013-12-18 18:22 ` Bounine, Alexandre
1 sibling, 0 replies; 9+ messages in thread
From: Josh Triplett @ 2013-12-14 20:34 UTC (permalink / raw)
To: Rashika Kheria; +Cc: linux-kernel, Matt Porter, Alexandre Bounine
On Sat, Dec 14, 2013 at 06:20:29PM +0530, Rashika Kheria wrote:
> This patch includes the header file linux/rio_drv.h in rio-driver.c
> because functions rio_dev_get(), rio_dev_put(), rio_register_driver()
> and rio_unregister_driver() have their prototype declarations in
> linux/rio_drv.h.
>
> Thus, it also eliminates the following warnings in rio-driver.c:
>
> drivers/rapidio/rio-driver.c:57:17: warning: no previous prototype for ‘rio_dev_get’ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:74:6: warning: no previous prototype for ‘rio_dev_put’ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:143:5: warning: no previous prototype for ‘rio_register_driver’ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:162:6: warning: no previous prototype for ‘rio_unregister_driver’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/rapidio/rio-driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rapidio/rio-driver.c b/drivers/rapidio/rio-driver.c
> index c9ae692..df73419 100644
> --- a/drivers/rapidio/rio-driver.c
> +++ b/drivers/rapidio/rio-driver.c
> @@ -13,6 +13,7 @@
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/rio.h>
> +#include <linux/rio_drv.h>
> #include <linux/rio_ids.h>
>
> #include "rio.h"
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 2/3] drivers: rapidio: Include appropriate header file in rio-driver.c
2013-12-14 12:50 ` [PATCH 2/3] drivers: rapidio: Include appropriate header file in rio-driver.c Rashika Kheria
2013-12-14 20:34 ` Josh Triplett
@ 2013-12-18 18:22 ` Bounine, Alexandre
1 sibling, 0 replies; 9+ messages in thread
From: Bounine, Alexandre @ 2013-12-18 18:22 UTC (permalink / raw)
To: Rashika Kheria, linux-kernel@vger.kernel.org
Cc: Matt Porter, josh@joshtriplett.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1678 bytes --]
On Sat, Dec 14, 2013 at 7:50AM, Rashika Kheria wrote:
> Subject: [PATCH 2/3] drivers: rapidio: Include appropriate header file
> in rio-driver.c
>
> This patch includes the header file linux/rio_drv.h in rio-driver.c
> because functions rio_dev_get(), rio_dev_put(), rio_register_driver()
> and rio_unregister_driver() have their prototype declarations in
> linux/rio_drv.h.
>
> Thus, it also eliminates the following warnings in rio-driver.c:
>
> drivers/rapidio/rio-driver.c:57:17: warning: no previous prototype for
> ‘rio_dev_get’ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:74:6: warning: no previous prototype for
> ‘rio_dev_put’ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:143:5: warning: no previous prototype for
> ‘rio_register_driver’ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:162:6: warning: no previous prototype for
> ‘rio_unregister_driver’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> ---
> drivers/rapidio/rio-driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rapidio/rio-driver.c b/drivers/rapidio/rio-
> driver.c
> index c9ae692..df73419 100644
> --- a/drivers/rapidio/rio-driver.c
> +++ b/drivers/rapidio/rio-driver.c
> @@ -13,6 +13,7 @@
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/rio.h>
> +#include <linux/rio_drv.h>
> #include <linux/rio_ids.h>
>
> #include "rio.h"
> --
> 1.7.9.5
Acked-by: Alexandre Bounine <alexandre.bounine@idt.com>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] drivers: rapidio: Remove unused function rio_remove_sysfs_dev_files() in rio-sysfs.c
2013-12-14 12:46 [PATCH 1/3] drivers: rapidio: Include appropriate header file in rio-access.c Rashika Kheria
2013-12-14 12:50 ` [PATCH 2/3] drivers: rapidio: Include appropriate header file in rio-driver.c Rashika Kheria
@ 2013-12-14 12:53 ` Rashika Kheria
2013-12-14 20:34 ` Josh Triplett
2013-12-18 16:38 ` Bounine, Alexandre
2013-12-14 20:33 ` [PATCH 1/3] drivers: rapidio: Include appropriate header file in rio-access.c Josh Triplett
2013-12-18 18:20 ` Bounine, Alexandre
3 siblings, 2 replies; 9+ messages in thread
From: Rashika Kheria @ 2013-12-14 12:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Matt Porter, Alexandre Bounine, josh
This patch removes the function rio_remove_sysfs_dev_files() in
rio-sysfs.c because it is unused.
Thus, it also eliminates the following warning in rio-sysfs.c:
drivers/rapidio/rio-sysfs.c:295:6: warning: no previous prototype for ‘rio_remove_sysfs_dev_files’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/rapidio/rio-sysfs.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/rapidio/rio-sysfs.c b/drivers/rapidio/rio-sysfs.c
index e0221c6..8929b9e 100644
--- a/drivers/rapidio/rio-sysfs.c
+++ b/drivers/rapidio/rio-sysfs.c
@@ -286,22 +286,6 @@ int rio_create_sysfs_dev_files(struct rio_dev *rdev)
return err;
}
-/**
- * rio_remove_sysfs_dev_files - cleanup RIO specific sysfs files
- * @rdev: device whose entries we should free
- *
- * Cleanup when @rdev is removed from sysfs.
- */
-void rio_remove_sysfs_dev_files(struct rio_dev *rdev)
-{
- device_remove_bin_file(&rdev->dev, &rio_config_attr);
- if (rdev->pef & RIO_PEF_SWITCH) {
- device_remove_file(&rdev->dev, &dev_attr_routes);
- device_remove_file(&rdev->dev, &dev_attr_lnext);
- device_remove_file(&rdev->dev, &dev_attr_hopcount);
- }
-}
-
static ssize_t bus_scan_store(struct bus_type *bus, const char *buf,
size_t count)
{
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 3/3] drivers: rapidio: Remove unused function rio_remove_sysfs_dev_files() in rio-sysfs.c
2013-12-14 12:53 ` [PATCH 3/3] drivers: rapidio: Remove unused function rio_remove_sysfs_dev_files() in rio-sysfs.c Rashika Kheria
@ 2013-12-14 20:34 ` Josh Triplett
2013-12-18 16:38 ` Bounine, Alexandre
1 sibling, 0 replies; 9+ messages in thread
From: Josh Triplett @ 2013-12-14 20:34 UTC (permalink / raw)
To: Rashika Kheria; +Cc: linux-kernel, Matt Porter, Alexandre Bounine
On Sat, Dec 14, 2013 at 06:23:10PM +0530, Rashika Kheria wrote:
> This patch removes the function rio_remove_sysfs_dev_files() in
> rio-sysfs.c because it is unused.
>
> Thus, it also eliminates the following warning in rio-sysfs.c:
> drivers/rapidio/rio-sysfs.c:295:6: warning: no previous prototype for ‘rio_remove_sysfs_dev_files’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/rapidio/rio-sysfs.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/rapidio/rio-sysfs.c b/drivers/rapidio/rio-sysfs.c
> index e0221c6..8929b9e 100644
> --- a/drivers/rapidio/rio-sysfs.c
> +++ b/drivers/rapidio/rio-sysfs.c
> @@ -286,22 +286,6 @@ int rio_create_sysfs_dev_files(struct rio_dev *rdev)
> return err;
> }
>
> -/**
> - * rio_remove_sysfs_dev_files - cleanup RIO specific sysfs files
> - * @rdev: device whose entries we should free
> - *
> - * Cleanup when @rdev is removed from sysfs.
> - */
> -void rio_remove_sysfs_dev_files(struct rio_dev *rdev)
> -{
> - device_remove_bin_file(&rdev->dev, &rio_config_attr);
> - if (rdev->pef & RIO_PEF_SWITCH) {
> - device_remove_file(&rdev->dev, &dev_attr_routes);
> - device_remove_file(&rdev->dev, &dev_attr_lnext);
> - device_remove_file(&rdev->dev, &dev_attr_hopcount);
> - }
> -}
> -
> static ssize_t bus_scan_store(struct bus_type *bus, const char *buf,
> size_t count)
> {
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH 3/3] drivers: rapidio: Remove unused function rio_remove_sysfs_dev_files() in rio-sysfs.c
2013-12-14 12:53 ` [PATCH 3/3] drivers: rapidio: Remove unused function rio_remove_sysfs_dev_files() in rio-sysfs.c Rashika Kheria
2013-12-14 20:34 ` Josh Triplett
@ 2013-12-18 16:38 ` Bounine, Alexandre
1 sibling, 0 replies; 9+ messages in thread
From: Bounine, Alexandre @ 2013-12-18 16:38 UTC (permalink / raw)
To: Rashika Kheria, linux-kernel@vger.kernel.org
Cc: Matt Porter, josh@joshtriplett.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 578 bytes --]
On Sat, Dec 14, 2013 at 7:53 AM Rashika Kheria wrote:
> Subject: [PATCH 3/3] drivers: rapidio: Remove unused function
> rio_remove_sysfs_dev_files() in rio-sysfs.c
>
> This patch removes the function rio_remove_sysfs_dev_files() in rio-
> sysfs.c because it is unused.
>
This function will be in use after RapidIO hot plug is added. This work in progress now.
To avoid bringing it back later I prefer to keep it.
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] drivers: rapidio: Include appropriate header file in rio-access.c
2013-12-14 12:46 [PATCH 1/3] drivers: rapidio: Include appropriate header file in rio-access.c Rashika Kheria
2013-12-14 12:50 ` [PATCH 2/3] drivers: rapidio: Include appropriate header file in rio-driver.c Rashika Kheria
2013-12-14 12:53 ` [PATCH 3/3] drivers: rapidio: Remove unused function rio_remove_sysfs_dev_files() in rio-sysfs.c Rashika Kheria
@ 2013-12-14 20:33 ` Josh Triplett
2013-12-18 18:20 ` Bounine, Alexandre
3 siblings, 0 replies; 9+ messages in thread
From: Josh Triplett @ 2013-12-14 20:33 UTC (permalink / raw)
To: Rashika Kheria; +Cc: linux-kernel, Matt Porter, Alexandre Bounine
On Sat, Dec 14, 2013 at 06:16:28PM +0530, Rashika Kheria wrote:
> This patch includes appropriate header file linux/rio_drv.h in
> rio-access.c because functions __rio_local_read_config_8,
> __rio_local_read_config_16, __rio_local_read_config_32,
> __rio_local_write_config_8, __rio_local_write_config_16,
> __rio_local_write_config_32, rio_mport_read_config_8,
> rio_mport_read_config_16, rio_mport_read_config_32,
> rio_mport_write_config_8, rio_mport_write_config_16,
> rio_mport_write_config_32 and rio_mport_send_doorbell have their
> prototype declaration in linux/rio_drv.h.
>
> Thus, it also eliminates the following warning in rio-access.c:
>
> drivers/rapidio/rio-access.c:79:1: warning: no previous prototype for ‘__rio_local_read_config_8’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:80:1: warning: no previous prototype for ‘__rio_local_read_config_16’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:81:1: warning: no previous prototype for ‘__rio_local_read_config_32’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:82:1: warning: no previous prototype for ‘__rio_local_write_config_8’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:83:1: warning: no previous prototype for ‘__rio_local_write_config_16’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:84:1: warning: no previous prototype for ‘__rio_local_write_config_32’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:139:1: warning: no previous prototype for ‘rio_mport_read_config_8’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:140:1: warning: no previous prototype for ‘rio_mport_read_config_16’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:141:1: warning: no previous prototype for ‘rio_mport_read_config_32’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:142:1: warning: no previous prototype for ‘rio_mport_write_config_8’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:143:1: warning: no previous prototype for ‘rio_mport_write_config_16’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:144:1: warning: no previous prototype for ‘rio_mport_write_config_32’ [-Wmissing-prototypes]
> drivers/rapidio/rio-access.c:163:5: warning: no previous prototype for ‘rio_mport_send_doorbell’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/rapidio/rio-access.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rapidio/rio-access.c b/drivers/rapidio/rio-access.c
> index a3824ba..5e6c7eb 100644
> --- a/drivers/rapidio/rio-access.c
> +++ b/drivers/rapidio/rio-access.c
> @@ -11,6 +11,7 @@
> */
>
> #include <linux/rio.h>
> +#include <linux/rio_drv.h>
> #include <linux/module.h>
>
> /*
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 1/3] drivers: rapidio: Include appropriate header file in rio-access.c
2013-12-14 12:46 [PATCH 1/3] drivers: rapidio: Include appropriate header file in rio-access.c Rashika Kheria
` (2 preceding siblings ...)
2013-12-14 20:33 ` [PATCH 1/3] drivers: rapidio: Include appropriate header file in rio-access.c Josh Triplett
@ 2013-12-18 18:20 ` Bounine, Alexandre
3 siblings, 0 replies; 9+ messages in thread
From: Bounine, Alexandre @ 2013-12-18 18:20 UTC (permalink / raw)
To: Rashika Kheria, linux-kernel@vger.kernel.org
Cc: Matt Porter, josh@joshtriplett.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1203 bytes --]
On Sat, Dec 14, 2013 at 7:46AM, Rashika Kheria wrote:
> Subject: [PATCH 1/3] drivers: rapidio: Include appropriate header file
> in rio-access.c
>
> This patch includes appropriate header file linux/rio_drv.h in
> rio-access.c because functions __rio_local_read_config_8,
> __rio_local_read_config_16, __rio_local_read_config_32,
> __rio_local_write_config_8, __rio_local_write_config_16,
> __rio_local_write_config_32, rio_mport_read_config_8,
> rio_mport_read_config_16, rio_mport_read_config_32,
... skip ...
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> ---
> drivers/rapidio/rio-access.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rapidio/rio-access.c b/drivers/rapidio/rio-
> access.c
> index a3824ba..5e6c7eb 100644
> --- a/drivers/rapidio/rio-access.c
> +++ b/drivers/rapidio/rio-access.c
> @@ -11,6 +11,7 @@
> */
>
> #include <linux/rio.h>
> +#include <linux/rio_drv.h>
> #include <linux/module.h>
>
> /*
> --
> 1.7.9.5
Acked-by: Alexandre Bounine <alexandre.bounine@idt.com>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 9+ messages in thread