From: Borislav Petkov <bp@alien8.de>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>,
Doug Thompson <dougthompson@xmission.com>,
linux-edac@vger.kernel.org, Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c
Date: Sat, 14 Dec 2013 21:42:28 +0100 [thread overview]
Message-ID: <20131214204228.GA12100@pd.tnic> (raw)
In-Reply-To: <CAMpEsFF2RjRYUvG7MivvWUmEV1kTn493=oNa30ASfQ+n+19akw@mail.gmail.com>
On Sat, Dec 14, 2013 at 11:47:10PM +0530, Rashika Kheria wrote:
> My gcc version is 4.6.3. You can trigger these warnings by adding
> -Wmissing-prototypes to KBUILD_CFLAGS in the top-level Makefile, and
Actually, you don't even have to do that - you only need to build with
W=1:
make W=1 drivers/edac/amd64_edac.o
We already enable -Wmissing-prototypes as an additional compiler warning
when building objects with the W= switch.
> do a build with defconfig or allyesconfig. It will show all warnings
> of missing prototype.
Ok, gcc man page says this detects global functions without prototypes
in a header but I guess it can be used to detect needlessly global
functions too. :)
I'll pick up your three patches,
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-12-14 20:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 13:58 [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c Rashika Kheria
2013-12-14 14:00 ` [PATCH 2/3] drivers: edac: Mark the function edac_create_debug_nodes() as static in edac_mc_sysfs.c Rashika Kheria
2013-12-14 20:28 ` Josh Triplett
2013-12-15 17:00 ` Borislav Petkov
2013-12-14 14:02 ` [PATCH 3/3] drivers: edac: Mark the function get_mci_for_node_id() as static in sb_edac.c Rashika Kheria
2013-12-14 20:28 ` Josh Triplett
2013-12-15 17:03 ` Borislav Petkov
2013-12-14 17:01 ` [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c Borislav Petkov
2013-12-14 18:17 ` Rashika Kheria
2013-12-14 20:42 ` Borislav Petkov [this message]
2013-12-14 20:28 ` Josh Triplett
2013-12-15 16:58 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214204228.GA12100@pd.tnic \
--to=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=josh@joshtriplett.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox